archtechx/enums
1
0
Fork 0
mirror of https://github.com/archtechx/enums.git synced 2025-12-12 11:14:05 +00:00
Code Activity

remove class name quoting in exceptions to match PHP behavior

Browse source
This commit is contained in:
Samuel Štancl 2024-01-12 21:56:42 +01:00
parent 79a410dd01
commit ca01a71ea0
2 changed files with 5 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/From.php
View file

@ -37,7 +37,7 @@ trait From
*/
public static function fromName(string $case): static
{
return static::tryFromName($case) ?? throw new ValueError('"' . $case . '" is not a valid name for enum "' . static::class . '"');
return static::tryFromName($case) ?? throw new ValueError('"' . $case . '" is not a valid name for enum ' . static::class . '');
}
/**

8
tests/Pest/FromTest.php
View file

@ -6,7 +6,7 @@ it('does not override the default BackedEnum from method')
it('does not override the default BackedEnum from method with errors', function () {
Status::from(2);
})->throws(ValueError::class, '2 is not a valid backing value for enum "Status"');
})->throws(ValueError::class, '2 is not a valid backing value for enum Status');
it('does not override the default BackedEnum tryFrom method')
->expect(Status::tryFrom(1))
@ -22,7 +22,7 @@ it('can select a case by name with from() for pure enums')
it('throws a value error when selecting a non-existent case with from() for pure enums', function () {
Role::from('NOBODY');
})->throws(ValueError::class, '"NOBODY" is not a valid name for enum "Role"');
})->throws(ValueError::class, '"NOBODY" is not a valid name for enum Role');
it('can select a case by name with tryFrom() for pure enums')
->expect(Role::tryFrom('GUEST'))
@ -38,7 +38,7 @@ it('can select a case by name with fromName() for pure enums')
it('throws a value error when selecting a non-existent case by name with fromName() for pure enums', function () {
Role::fromName('NOBODY');
})->throws(ValueError::class, '"NOBODY" is not a valid name for enum "Role"');
})->throws(ValueError::class, '"NOBODY" is not a valid name for enum Role');
it('can select a case by name with tryFromName() for pure enums')
->expect(Role::tryFromName('GUEST'))
@ -54,7 +54,7 @@ it('can select a case by name with fromName() for backed enums')
it('throws a value error when selecting a non-existent case by name with fromName() for backed enums', function () {
Status::fromName('NOTHING');
})->throws(ValueError::class, '"NOTHING" is not a valid name for enum "Status"');
})->throws(ValueError::class, '"NOTHING" is not a valid name for enum Status');
it('can select a case by name with tryFromName() for backed enums')
->expect(Status::tryFromName('DONE'))