fix: just handle failures in closures correctly

src/JobPipeline.php

@@ -67,7 +67,7 @@ class JobPipeline implements ShouldQueue
             }
 
             try {
-                $result = app()->call($job, $this->passable);
+                $result = app()->call($job);
             } catch (Throwable $exception) {
                 if (is_array($job) && method_exists(get_class($job[0]), 'failed')) {
                     call_user_func_array([$job[0], 'failed'], [$exception]);

tests/JobPipelineTest.php

@@ -2,6 +2,7 @@
 
 namespace Stancl\JobPipeline\Tests;
 
+use Exception;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Support\Facades\Event;
 use Illuminate\Support\Facades\Queue;
@@ -169,37 +170,27 @@ class JobPipelineTest extends TestCase
     }
 
     /** @test */
-    public function send_can_pass_parameters_to_method()
+    public function failures_in_closures_will_throw_correctly()
     {
+        $passes = true;
+
         Event::listen(TestEvent::class, JobPipeline::make([
-            [new FooJobWithMethod(), 'foo']
+            function () use (&$passes) {
-        ])->send(function () {
+                try {
+                    throw new Exception('foobar');
+                } catch (Exception) {
+                    $passes = false;
+                }
+            }
+        ])->send(function (TestEvent $event) {
             return $this->valuestore;
         })->toListener());
 
-        $this->assertFalse($this->valuestore->has('foo'));
-
         event(new TestEvent(new TestModel()));
 
-        $this->assertSame('bar', $this->valuestore->get('foo'));
+        sleep(1);
-    }
 
-    /** @test */
+        $this->assertFalse($passes);
-    public function send_can_pass_parameters_to_method_with_at_syntax()
-    {
-        app()->bind('FooJobWithMethod', fn () => new FooJobWithMethod());
-
-        Event::listen(TestEvent::class, JobPipeline::make([
-            'FooJobWithMethod@foo'
-        ])->send(function () {
-            return $this->valuestore;
-        })->toListener());
-
-        $this->assertFalse($this->valuestore->has('foo'));
-
-        event(new TestEvent(new TestModel()));
-
-        $this->assertSame('bar', $this->valuestore->get('foo'));
     }
 }
 
@@ -321,14 +312,3 @@ class ExceptionJob
         $this->valuestore->put('exeception', $e->getMessage());
     }
 }
-
-class FooJobWithMethod
-{
-    // variadic arguments must be used so the container doesn't try to inject any value
-    public function foo(...$arguments)
-    {
-        [$valuestore] = $arguments;
-
-        $valuestore->put('foo', 'bar');
-    }
-}