From 0a2eef4db49f41b3d55d4270b9d4767bac1d8ec9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Samuel=20=C5=A0tancl?= Date: Thu, 6 Mar 2025 17:38:20 +0100 Subject: [PATCH] Laravel 12 support (#44) * Laravel 12 support * bump dev dependencies * resolve phpstan issue, restrict version constraints * fix phpcsfixer CI action --- .github/workflows/ci.yml | 6 +++--- composer.json | 12 ++++++------ phpstan.neon | 2 +- src/SEOManager.php | 2 +- 4 files changed, 11 insertions(+), 11 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8172838..e29f1e1 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,7 +11,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - laravel: [10, 11] + laravel: [10, 11, 12] steps: - uses: actions/checkout@v2 @@ -61,6 +61,6 @@ jobs: - name: Commit changes from php-cs-fixer uses: EndBug/add-and-commit@v5 with: - author_name: "PHP CS Fixer" - author_email: "phpcsfixer@example.com" + author_name: "github-actions[bot]" + author_email: "github-actions[bot]@users.noreply.github.com" message: Fix code style (php-cs-fixer) diff --git a/composer.json b/composer.json index fe1ea2e..4aa74ab 100644 --- a/composer.json +++ b/composer.json @@ -24,14 +24,14 @@ }, "require": { "php": "^8.2", - "illuminate/support": "^10.0|^11.0", - "illuminate/view": "^10.0|^11.0" + "illuminate/support": "^10.0|^11.0|^12.0", + "illuminate/view": "^10.0|^11.0|^12.0" }, "require-dev": { - "orchestra/testbench": "^8.0|^9.0", - "nunomaduro/larastan": "^2.4", - "pestphp/pest": "^2.0", - "pestphp/pest-plugin-laravel": "^2.0", + "orchestra/testbench": ">=8.0", + "nunomaduro/larastan": ">=2.4", + "pestphp/pest": ">=2.0", + "pestphp/pest-plugin-laravel": ">=2.0", "intervention/image": "^2.7" }, "extra": { diff --git a/phpstan.neon b/phpstan.neon index 9cc794e..d8f0cf3 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -10,10 +10,10 @@ parameters: universalObjectCratesClasses: - Illuminate\Routing\Route - ArchTech\SEO\SEOManager - checkMissingIterableValueType: false ignoreErrors: - '#^Method ArchTech\\SEO\\SEOManager::flipp\(\) should return static\(ArchTech\\SEO\\SEOManager\)\|string but returns array\|string\|null\.$#' - '#^Method ArchTech\\SEO\\SEOManager::previewify\(\) should return static\(ArchTech\\SEO\\SEOManager\)\|string but returns array\|string\|null\.$#' - '#^Method ArchTech\\SEO\\SEOManager::render\(\) has parameter \$args with no type specified\.$#' - '#^Parameter \#1 \$value of function e expects#' + - identifier: missingType.iterableValue diff --git a/src/SEOManager.php b/src/SEOManager.php index a24d0c2..b3d603a 100644 --- a/src/SEOManager.php +++ b/src/SEOManager.php @@ -240,7 +240,7 @@ class SEOManager /** Has a specific tag been set? */ public function hasRawTag(string $key): bool { - return isset($this->tags[$key]) && ($this->tags[$key] !== null); + return isset($this->tags[$key]); } /** Has a specific meta tag been set? */