archtechx/laravel-seo
1
0
Fork 0
mirror of https://github.com/archtechx/laravel-seo.git synced 2025-12-12 01:44:03 +00:00
Code Activity

fix tests broken by #39

Browse source
This commit is contained in:
Samuel Štancl 2024-11-23 00:45:49 +01:00
parent f4ec8c0fab
commit c768bb7d60
7 changed files with 26 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

4
README.md
View file

@ -140,8 +140,8 @@ To add more tags to the document head, you can use the `tag()` and `rawTag()` me
```php ```php
seo()->tag('fb:image', asset('foo')); seo()->tag('fb:image', asset('foo'));
seo()->rawTag('<meta property="fb:url" content="bar" />'); seo()->rawTag('<meta property="fb:url" content="bar">');
seo()->rawTag('fb_url', '<meta property="fb:url" content="bar" />'); // Keyed, allows overrides later on seo()->rawTag('fb_url', '<meta property="fb:url" content="bar">'); // Keyed, allows overrides later on
``` ```
### Canonical URL ### Canonical URL

10
resources/views/components/extensions/twitter.blade.php
View file

@ -1,6 +1,6 @@
<meta name="twitter:card" content="summary_large_image"> <meta name="twitter:card" content="summary_large_image">
@if(seo('twitter.creator')) <meta name="twitter:creator" content="@seo('twitter.creator')" /> @endif @if(seo('twitter.creator')) <meta name="twitter:creator" content="@seo('twitter.creator')"> @endif
@if(seo('twitter.site')) <meta name="twitter:site" content="@seo('twitter.site')" /> @endif @if(seo('twitter.site')) <meta name="twitter:site" content="@seo('twitter.site')"> @endif
@if(seo('twitter.title')) <meta name="twitter:title" content="@seo('twitter.title')" /> @endif @if(seo('twitter.title')) <meta name="twitter:title" content="@seo('twitter.title')"> @endif
@if(seo('twitter.description')) <meta name="twitter:description" content="@seo('twitter.description')" /> @endif @if(seo('twitter.description')) <meta name="twitter:description" content="@seo('twitter.description')"> @endif
@if(seo('twitter.image')) <meta name="twitter:image" content="@seo('twitter.image')" /> @endif @if(seo('twitter.image')) <meta name="twitter:image" content="@seo('twitter.image')"> @endif

2
src/SEOManager.php
View file

@ -264,7 +264,7 @@ class SEOManager
{ {
$content = e($content); $content = e($content);
$this->rawTag("meta.{$property}", "<meta property=\"{$property}\" content=\"{$content}\" />"); $this->rawTag("meta.{$property}", "<meta property=\"{$property}\" content=\"{$content}\">");
return $this; return $this;
} }

4
tests/Pest/ExtensionTest.php
View file

@ -40,7 +40,7 @@ test('extensions can use custom blade paths', function () {
seo()->facebookTitle('abc'); seo()->facebookTitle('abc');
expect(meta())->toContain('<meta name="facebook:title" content="ABC" />'); expect(meta())->toContain('<meta name="facebook:title" content="ABC">');
}); });
test('twitter falls back to the default values', function () { test('twitter falls back to the default values', function () {
@ -56,7 +56,7 @@ test('twitter falls back to the default values', function () {
expect(seo('twitter.description'))->toBe('bar'); expect(seo('twitter.description'))->toBe('bar');
expect(seo('description'))->toBe('baz'); expect(seo('description'))->toBe('baz');
expect(meta())->toContain('<meta name="twitter:title" content="foo" />'); expect(meta())->toContain('<meta name="twitter:title" content="foo">');
}); });
test('extensions are automatically enabled when values for them are set', function () { test('extensions are automatically enabled when values for them are set', function () {

18
tests/Pest/ManagerTest.php
View file

@ -86,7 +86,7 @@ test('setting the defaults returns the manager instance', function () {
test('meta tags can be added to the template', function () { test('meta tags can be added to the template', function () {
seo()->tag('fb:image', 'foo'); seo()->tag('fb:image', 'foo');
expect(meta())->toContain('<meta property="fb:image" content="foo" />'); expect(meta())->toContain('<meta property="fb:image" content="foo">');
}); });
test('raw tags can be added to the template', function () { test('raw tags can be added to the template', function () {
@ -114,8 +114,8 @@ test('canonical url can be read from request', function () {
seo()->withUrl(); seo()->withUrl();
expect(meta()) expect(meta())
->toContain('<meta property="og:url" content="http://localhost" />') ->toContain('<meta property="og:url" content="http://localhost">')
->toContain('<link rel="canonical" href="http://localhost" />'); ->toContain('<link rel="canonical" href="http://localhost">');
}); });
test('canonical url can be changed', function () { test('canonical url can be changed', function () {
@ -124,8 +124,8 @@ test('canonical url can be changed', function () {
seo()->url('http://foo.com/bar'); seo()->url('http://foo.com/bar');
expect(meta()) expect(meta())
->toContain('<meta property="og:url" content="http://foo.com/bar" />') ->toContain('<meta property="og:url" content="http://foo.com/bar">')
->toContain('<link rel="canonical" href="http://foo.com/bar" />'); ->toContain('<link rel="canonical" href="http://foo.com/bar">');
}); });
test('og:title can be overridden using a tag', function () { test('og:title can be overridden using a tag', function () {
@ -134,16 +134,16 @@ test('og:title can be overridden using a tag', function () {
expect(meta()) expect(meta())
->toContain('<title>foo</title>') ->toContain('<title>foo</title>')
->toContain('<meta property="og:title" content="bar" />'); ->toContain('<meta property="og:title" content="bar">');
}); });
test('type can be overridden using the type method', function () { test('type can be overridden using the type method', function () {
expect(meta())->toContain('<meta property="og:type" content="website" />'); // default expect(meta())->toContain('<meta property="og:type" content="website">'); // default
seo()->type('foo'); seo()->type('foo');
expect(meta()) expect(meta())
->toContain('<meta property="og:type" content="foo" />') // overridden ->toContain('<meta property="og:type" content="foo">') // overridden
->not()->toContain('website'); ->not()->toContain('website');
}); });
@ -155,5 +155,5 @@ test('og:locale is not included by default', function () {
test('og:locale can be added to the template', function () { test('og:locale can be added to the template', function () {
seo()->locale('de_DE'); seo()->locale('de_DE');
expect(meta())->toContain('<meta property="og:locale" content="de_DE" />'); expect(meta())->toContain('<meta property="og:locale" content="de_DE">');
}); });

12
tests/Pest/SanitizationTest.php
View file

@ -13,8 +13,8 @@ test('opengraph methods properly sanitize input', function (string $method, stri
expect($meta)->not()->toContain('content="Testing string " with several \' XSS characters </title> " . \' ."'); expect($meta)->not()->toContain('content="Testing string " with several \' XSS characters </title> " . \' ."');
expect($meta)->not()->toContain("content=\"{$unsanitizedContent}\""); expect($meta)->not()->toContain("content=\"{$unsanitizedContent}\"");
expect($meta)->toContain("<meta property=\"$property\" content=\"{$sanitizedContent}\" />"); expect($meta)->toContain("<meta property=\"$property\" content=\"{$sanitizedContent}\">");
expect($meta)->toContain("<meta property=\"$property\" content=\"Testing string &quot; with several &#039; XSS characters &lt;/title&gt; &quot; . &#039; .\" />"); expect($meta)->toContain("<meta property=\"$property\" content=\"Testing string &quot; with several &#039; XSS characters &lt;/title&gt; &quot; . &#039; .\">");
})->with([ })->with([
['site', 'og:site_name'], ['site', 'og:site_name'],
['url', 'og:url'], ['url', 'og:url'],
@ -37,8 +37,8 @@ test('the twitter extension properly sanitizes input', function (string $method,
expect($meta)->not()->toContain('content="Testing string " with several \' XSS characters </title> " . \' ."'); expect($meta)->not()->toContain('content="Testing string " with several \' XSS characters </title> " . \' ."');
expect($meta)->not()->toContain("content=\"{$unsanitizedContent}\""); expect($meta)->not()->toContain("content=\"{$unsanitizedContent}\"");
expect($meta)->toContain("<meta name=\"$property\" content=\"{$sanitizedContent}\" />"); expect($meta)->toContain("<meta name=\"$property\" content=\"{$sanitizedContent}\">");
expect($meta)->toContain("<meta name=\"$property\" content=\"Testing string &quot; with several &#039; XSS characters &lt;/title&gt; &quot; . &#039; .\" />"); expect($meta)->toContain("<meta name=\"$property\" content=\"Testing string &quot; with several &#039; XSS characters &lt;/title&gt; &quot; . &#039; .\">");
})->with([ })->with([
['twitterCreator', 'twitter:creator'], ['twitterCreator', 'twitter:creator'],
['twitterSite', 'twitter:site'], ['twitterSite', 'twitter:site'],
@ -65,8 +65,8 @@ test('the title method properly sanitizes both tags', function () {
expect($meta)->toContain("<title>{$sanitizedContent}</title>"); expect($meta)->toContain("<title>{$sanitizedContent}</title>");
expect($meta)->toContain("<title>Testing string &quot; with several &#039; XSS characters &lt;/title&gt; &quot; . &#039; .</title>"); expect($meta)->toContain("<title>Testing string &quot; with several &#039; XSS characters &lt;/title&gt; &quot; . &#039; .</title>");
expect($meta)->toContain("<meta property=\"og:title\" content=\"{$sanitizedContent}\" />"); expect($meta)->toContain("<meta property=\"og:title\" content=\"{$sanitizedContent}\">");
expect($meta)->toContain("<meta property=\"og:title\" content=\"Testing string &quot; with several &#039; XSS characters &lt;/title&gt; &quot; . &#039; .\" />"); expect($meta)->toContain("<meta property=\"og:title\" content=\"Testing string &quot; with several &#039; XSS characters &lt;/title&gt; &quot; . &#039; .\">");
}); });
test('seo blade directive calls are sanitized', function () { test('seo blade directive calls are sanitized', function () {

2
tests/views/components/facebook.blade.php
View file

@ -1 +1 @@
<meta name="facebook:title" content="{{ strtoupper(seo()->facebookTitle) }}" /> <meta name="facebook:title" content="{{ strtoupper(seo()->facebookTitle) }}">