[1.8.0] Use strict types (#115)

* Use strict types

* Apply fixes from StyleCI

* Fix str_repeat

* Fix false json decode

.styleci.yml

@@ -1,6 +1,7 @@
 preset: laravel
 enabled:
 - native_function_invocation
+- declare_strict_types
 disabled:
 - concat_without_spaces
 - ternary_operator_spaces

assets/config.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 return [
     'storage_driver' => 'Stancl\Tenancy\StorageDrivers\DatabaseStorageDriver',
     'storage' => [

assets/migrations/2019_08_08_000000_create_tenants_table.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Illuminate\Support\Facades\Schema;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Database\Migrations\Migration;

src/CacheManager.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy;
 
 use Illuminate\Cache\CacheManager as BaseCacheManager;

src/Commands/Install.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Commands;
 
 use Illuminate\Console\Command;

src/Commands/Migrate.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Commands;
 
 use Illuminate\Console\Command;

src/Commands/Rollback.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Commands;
 
 use Illuminate\Console\Command;

src/Commands/Run.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Commands;
 
 use Illuminate\Console\Command;

src/Commands/Seed.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Commands;
 
 use Stancl\Tenancy\DatabaseManager;

src/Commands/TenantList.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Commands;
 
 use Illuminate\Console\Command;

src/Controllers/TenantAssetsController.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Controllers;
 
 use Illuminate\Routing\Controller;

src/DatabaseManager.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy;
 
 use Stancl\Tenancy\Jobs\QueuedTenantDatabaseCreator;

src/Exceptions/CannotChangeUuidOrDomainException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Exceptions;
 
 class CannotChangeUuidOrDomainException extends \Exception

src/Exceptions/DatabaseManagerNotRegisteredException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Exceptions;
 
 class DatabaseManagerNotRegisteredException extends \Exception

src/Exceptions/PhpRedisNotInstalledException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Exceptions;
 
 class PhpRedisNotInstalledException extends \Exception

src/Exceptions/TenantCouldNotBeIdentifiedException.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Exceptions;
 
 class TenantCouldNotBeIdentifiedException extends \Exception

src/GlobalCacheFacade.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy;
 
 use Illuminate\Support\Facades\Facade;

src/Interfaces/StorageDriver.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Interfaces;
 
 interface StorageDriver

src/Interfaces/TenantDatabaseManager.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Interfaces;
 
 interface TenantDatabaseManager

src/Interfaces/UniqueIdentifierGenerator.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Interfaces;
 
 interface UniqueIdentifierGenerator

src/Jobs/QueuedTenantDatabaseCreator.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Jobs;
 
 use Illuminate\Bus\Queueable;

src/Jobs/QueuedTenantDatabaseDeleter.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Jobs;
 
 use Illuminate\Bus\Queueable;

src/Middleware/InitializeTenancy.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Middleware;
 
 use Closure;

src/StorageDrivers/DatabaseStorageDriver.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\StorageDrivers;
 
 use Stancl\Tenancy\Tenant;

src/StorageDrivers/RedisStorageDriver.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\StorageDrivers;
 
 use Illuminate\Support\Facades\Redis;

src/TenancyFacade.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy;
 
 use Illuminate\Support\Facades\Facade;

src/TenancyServiceProvider.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy;
 
 use Laravel\Telescope\Telescope;

src/Tenant.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy;
 
 use Illuminate\Database\Eloquent\Model;

src/TenantDatabaseManagers/MySQLDatabaseManager.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\TenantDatabaseManagers;
 
 use Illuminate\Support\Facades\DB;

src/TenantDatabaseManagers/PostgreSQLDatabaseManager.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\TenantDatabaseManagers;
 
 use Illuminate\Support\Facades\DB;

src/TenantDatabaseManagers/SQLiteDatabaseManager.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\TenantDatabaseManagers;
 
 use Stancl\Tenancy\Interfaces\TenantDatabaseManager;

src/TenantManager.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy;
 
 use Stancl\Tenancy\Interfaces\StorageDriver;
@@ -383,7 +385,9 @@ final class TenantManager
     protected function jsonDecodeArrayValues(array $array)
     {
         \array_walk($array, function (&$value, $key) {
-            $value = \json_decode($value, true);
+            if ($value) {
+                $value = \json_decode($value, true);
+            }
         });
 
         return $array;

src/TenantRouteServiceProvider.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy;
 
 use Illuminate\Support\Facades\Route;

src/Traits/BootstrapsTenancy.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Traits;
 
 use Stancl\Tenancy\CacheManager;

src/Traits/DealsWithMigrations.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Traits;
 
 trait DealsWithMigrations

src/Traits/HasATenantsOption.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Traits;
 
 use Symfony\Component\Console\Input\InputOption;

src/Traits/TenantManagerEvents.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Traits;
 
 use Illuminate\Support\Collection;

src/UUIDGenerator.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy;
 
 use Stancl\Tenancy\Interfaces\UniqueIdentifierGenerator;

src/helpers.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 use Stancl\Tenancy\TenantManager;
 
 if (! \function_exists('tenancy')) {

src/routes.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 Route::get('/tenancy/assets/{path}', 'Stancl\Tenancy\Controllers\TenantAssetsController@asset')
     ->where('path', '(.*)')
     ->name('stancl.tenancy.asset');

tests/BootstrapsTenancyTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 use Illuminate\Support\Facades\Redis;

tests/CacheManagerTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 class CacheManagerTest extends TestCase

tests/CommandsTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 use Illuminate\Support\Facades\DB;

tests/DataSeparationTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 use Illuminate\Support\Str;

tests/DatabaseManagerTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 use Stancl\Tenancy\DatabaseManager;

tests/Etc/ConsoleKernel.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests\Etc;
 
 use Orchestra\Testbench\Console\Kernel;

tests/Etc/ExampleCommand.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests\Etc;
 
 use Illuminate\Console\Command;

tests/Etc/ExampleSeeder.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests\Etc;
 
 use Illuminate\Support\Str;

tests/Etc/HttpKernel.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests\Etc;
 
 use Illuminate\Foundation\Http\Kernel;

tests/FacadeTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 use Tenant;

tests/GlobalCacheTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 use GlobalCache;

tests/QueueTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 use Illuminate\Bus\Queueable;

tests/ReidentificationTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 class ReidentificationTest extends TestCase

tests/TenantAssetTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 class TenantAssetTest extends TestCase

tests/TenantDatabaseManagerTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 use Illuminate\Support\Facades\DB;

tests/TenantManagerEventsTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 use Tenant;

tests/TenantManagerTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 use Illuminate\Support\Facades\DB;

tests/TenantRedirectMacroTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 use Route;

tests/TenantStorageTest.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 use Stancl\Tenancy\Tenant;

tests/TestCase.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Stancl\Tenancy\Tests;
 
 use Illuminate\Support\Facades\Redis;
@@ -160,7 +162,7 @@ abstract class TestCase extends \Orchestra\Testbench\TestCase
 
     public function randomString(int $length = 10)
     {
-        return \substr(\str_shuffle(\str_repeat($x = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ', \ceil($length / \strlen($x)))), 1, $length);
+        return \substr(\str_shuffle(\str_repeat($x = '0123456789abcdefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ', (int) (\ceil($length / \strlen($x))))), 1, $length);
     }
 
     public function isContainerized()