From 35d96b5b6f075e0ea24633378c938b82a101bfff Mon Sep 17 00:00:00 2001 From: lukinovec Date: Tue, 15 Sep 2026 11:09:40 +0200 Subject: [PATCH] Use rmdir instead of deleteDirectory rmdir refuses to delete non-empty directories, so it's the better alternative to deleteDirectory here. --- src/Actions/RemoveStorageSymlinksAction.php | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/Actions/RemoveStorageSymlinksAction.php b/src/Actions/RemoveStorageSymlinksAction.php index ce808ab4..d04faf5c 100644 --- a/src/Actions/RemoveStorageSymlinksAction.php +++ b/src/Actions/RemoveStorageSymlinksAction.php @@ -68,7 +68,10 @@ class RemoveStorageSymlinksAction // Remove the directories CreateStorageSymlinksAction created for the symlink // until a non-empty one is reached. while (str_starts_with(rtrim($directory, '/\\'), rtrim($publicRoot, '/\\') . DIRECTORY_SEPARATOR) && $files->isEmptyDirectory($directory)) { - $files->deleteDirectory($directory); + if (! @rmdir($directory)) { + // Stop the loop if the directory couldn't be removed + break; + } $directory = dirname($directory); }