archtechx/tenancy
1
0
Fork 0
mirror of https://github.com/archtechx/tenancy.git synced 2026-06-21 04:24:04 +00:00
Code Activity

Move mysql charset/collation validation assertions to a dedicated test

Browse source
This commit is contained in:
lukinovec 2026-06-08 11:51:35 +02:00
parent d28abdec89
commit 36782ebee7
1 changed files with 15 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

33
tests/TenantDatabaseManagerTest.php
View file

@ -571,24 +571,6 @@ test('database managers validate parameters that cannot be bound', function ($dr
expect(fn () => $manager->deleteDatabase($tenant)) expect(fn () => $manager->deleteDatabase($tenant))
->toThrow(InvalidArgumentException::class, 'Forbidden character'); ->toThrow(InvalidArgumentException::class, 'Forbidden character');
if ($driver === 'mysql') {
// MySQLDatabaseManager reads charset/collation from config.
// An exception is thrown during validation if the parameter is not a string.
config(['database.connections.mysql.charset' => []]);
DB::purge('mysql');
$tenantWithNonStringCharset = Tenant::make([
'tenancy_db_name' => 'valid_db_name',
]);
expect(fn () => $manager->createDatabase($tenantWithNonStringCharset))
->toThrow(InvalidArgumentException::class, 'Parameter has to be a string.');
// Restore the default charset
config(['database.connections.mysql.charset' => 'utf8mb4']);
DB::purge('mysql');
}
} else { } else {
// Invalid username, createUser() and deleteUser() should // Invalid username, createUser() and deleteUser() should
// throw an invalid argument exception. // throw an invalid argument exception.
@ -646,6 +628,21 @@ test('database managers validate parameters that cannot be bound', function ($dr
} }
})->with('database_managers'); })->with('database_managers');
test('mysql database manager validates charset and collation correctly', function () {
$manager = app(MySQLDatabaseManager::class);
$manager->setConnection('mysql');
config(['database.connections.mysql.charset' => []]);
DB::purge('mysql');
$tenant = Tenant::make([
'tenancy_db_name' => 'valid_db_name',
]);
expect(fn () => $manager->createDatabase($tenant))
->toThrow(InvalidArgumentException::class, 'Parameter has to be a string.');
});
test('sqlite database manager validates database names correctly', function () { test('sqlite database manager validates database names correctly', function () {
$manager = app(SQLiteDatabaseManager::class); $manager = app(SQLiteDatabaseManager::class);