From 3951680a9814fe34f40e42738aac05a65777c960 Mon Sep 17 00:00:00 2001 From: Abrar Ahmad Date: Tue, 9 Aug 2022 10:19:53 +0500 Subject: [PATCH] comments --- .github/workflows/ci.yml | 3 +-- tests/ResourceSyncingTest.php | 4 ++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 14d24f7d..f0fe927a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -2,7 +2,6 @@ name: CI env: COMPOSE_INTERACTIVE_NO_CLI: 1 - PHP_CS_FIXER_IGNORE_ENV: 1 GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} on: @@ -39,7 +38,7 @@ jobs: - name: Run php-cs-fixer run: $HOME/.composer/vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.php - name: Commit changes from php-cs-fixer - uses: EndBug/add-and-commit@v9 + uses: EndBug/add-and-commit@v5 with: author_name: "PHP CS Fixer" author_email: "phpcsfixer@example.com" diff --git a/tests/ResourceSyncingTest.php b/tests/ResourceSyncingTest.php index 99440301..cfa6ce0d 100644 --- a/tests/ResourceSyncingTest.php +++ b/tests/ResourceSyncingTest.php @@ -150,7 +150,7 @@ test('creating the resource in tenant database creates it in central database an tenancy()->end(); - // Asset user was created + // assert user was created expect(CentralUser::first()->global_id)->toBe('acme'); }); @@ -552,7 +552,7 @@ function creatingResourceInTenantDatabaseCreatesAndMapInCentralDatabase() tenancy()->end(); - // Asset user was created + // Assert user was created expect(CentralUser::first()->global_id)->toBe('acme'); expect(CentralUser::first()->role)->toBe('commenter');