Better solution for tenant DB exception

src/Bootstrappers/DatabaseTenancyBootstrapper.php

@@ -22,9 +22,13 @@ class DatabaseTenancyBootstrapper implements TenancyBootstrapper
     public function bootstrap(Tenant $tenant)
     {
         /** @var TenantWithDatabase $tenant */
-        $database = $tenant->database()->getName();
+
-        if (! $tenant->database()->manager()->databaseExists($database)) {
+        // Better debugging, but breaks cached lookup in prod
-            throw new TenantDatabaseDoesNotExistException($database);
+        if (app()->environment('local')) {
+            $database = $tenant->database()->getName();
+            if (! $tenant->database()->manager()->databaseExists($database)) {
+                throw new TenantDatabaseDoesNotExistException($database);
+            }
         }
 
         $this->database->connectToTenant($tenant);

src/Exceptions/TenantCouldNotBeIdentifiedByPathException.php

@@ -21,7 +21,7 @@ class TenantCouldNotBeIdentifiedByPathException extends TenantCouldNotBeIdentifi
         return BaseSolution::create('Tenant could not be identified on this path')
             ->setSolutionDescription('Did you forget to create a tenant for this path?')
             ->setDocumentationLinks([
-                'Creating Tenants' => 'https://tenancyforlaravel.com/docs/v2/creating-tenants/', // todo update link for v3
+                'Creating Tenants' => 'https://tenancyforlaravel.com/docs/v3/tenants/',
             ]);
     }
 }

src/Exceptions/TenantCouldNotBeIdentifiedByRequestDataException.php

@@ -21,7 +21,7 @@ class TenantCouldNotBeIdentifiedByRequestDataException extends TenantCouldNotBeI
         return BaseSolution::create('Tenant could not be identified with this request data')
             ->setSolutionDescription('Did you forget to create a tenant with this id?')
             ->setDocumentationLinks([
-                'Creating Tenants' => 'https://tenancyforlaravel.com/docs/v2/creating-tenants/', // todo update link for v3
+                'Creating Tenants' => 'https://tenancyforlaravel.com/docs/v3/tenants/',
             ]);
     }
 }

src/Exceptions/TenantCouldNotBeIdentifiedOnDomainException.php

@@ -21,7 +21,7 @@ class TenantCouldNotBeIdentifiedOnDomainException extends TenantCouldNotBeIdenti
         return BaseSolution::create('Tenant could not be identified on this domain')
             ->setSolutionDescription('Did you forget to create a tenant for this domain?')
             ->setDocumentationLinks([
-                'Creating Tenants' => 'https://tenancyforlaravel.com/docs/v2/creating-tenants/', // todo update link for v3
+                'Creating Tenants' => 'https://tenancyforlaravel.com/docs/v3/tenants/',
             ]);
     }
 }

tests/CachedTenantResolverTest.php

@@ -109,6 +109,4 @@ class CachedTenantResolverTest extends TestCase
         $this->assertTrue($tenant->is(app(DomainTenantResolver::class)->resolve('bar')));
         $this->assertNotEmpty(DB::getQueryLog()); // not empty
     }
-
-    // todo2 at some point in the future, we could write invalidation tests for the other resolvers too
 }