archtechx/tenancy
1
0
Fork 0
mirror of https://github.com/archtechx/tenancy.git synced 2026-06-21 09:24:03 +00:00
Code Activity

Consider null parameters invalid

Browse source 
Parameters passed to validateParameter should always be non-null, and if they're null, an exception is thrown.
This commit is contained in:
lukinovec 2026-06-09 08:15:07 +02:00
parent fbffeb84b3
commit 48b8aac42d
3 changed files with 11 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/Database/Concerns/ValidatesDatabaseParameters.php
View file

@ -50,20 +50,19 @@ trait ValidatesDatabaseParameters
*
* By default, only the characters in allowedParameterCharacters() are allowed.
*
* Null parameters are skipped.
*
* @throws InvalidArgumentException
*/
protected function validateParameter(string|array|null $parameters, string|null $allowedCharacters = null): void
{
if ($parameters === null) {
throw new InvalidArgumentException('Parameter cannot be null.');
}
$allowedCharacters ??= $this->allowedParameterCharacters();
foreach (Arr::wrap($parameters) as $parameter) {
if (is_null($parameter)) {
// Skip if there's nothing to validate
// (e.g. when $tenant->database()->getUsername() of an
// improperly created tenant is null and it gets passed).
continue;
throw new InvalidArgumentException('Parameter cannot be null.');
}
if (is_numeric($parameter)) {