diff --git a/phpstan.neon b/phpstan.neon index ba269e5e..8a48a672 100644 --- a/phpstan.neon +++ b/phpstan.neon @@ -51,6 +51,10 @@ parameters: - '#Method Stancl\\Tenancy\\Tenancy::cachedResolvers\(\) should return array#' - '#Access to an undefined property Stancl\\Tenancy\\Middleware\\IdentificationMiddleware\:\:\$tenancy#' - '#Access to an undefined property Stancl\\Tenancy\\Middleware\\IdentificationMiddleware\:\:\$resolver#' + - + message: '#string\|false#' + paths: + - src/Controllers/TenantAssetController.php checkMissingIterableValueType: false checkGenericClassInNonGenericObjectType: false # later we may want to enable this diff --git a/src/Controllers/TenantAssetController.php b/src/Controllers/TenantAssetController.php index cada0864..cfa130c5 100644 --- a/src/Controllers/TenantAssetController.php +++ b/src/Controllers/TenantAssetController.php @@ -57,7 +57,8 @@ class TenantAssetController implements HasMiddleware // todo@docs this was renam $this->abortIf(! str($attemptedPath)->startsWith($allowedRoot), 'Accessing a file outside the storage root'); } - protected function abortIf($condition, $exceptionMessage): void + /** @return void|never */ + protected function abortIf(bool $condition, string $exceptionMessage = ''): void { if ($condition) { if (app()->runningUnitTests()) {