archtechx/tenancy
1
0
Fork 0
mirror of https://github.com/archtechx/tenancy.git synced 2026-08-06 07:54:03 +00:00
Code Activity

Simplify channel-passing test

Browse source 
Remove the with() -- the test ran four times with the same TestingBroadcaster, so the only tested broadcaster was actually the testing one. Running the test just once is enough, the same things are still covered.
This commit is contained in:
lukinovec 2026-07-12 12:20:40 +02:00
parent 9e6e0a988b
commit 5911619887
1 changed files with 5 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

18
tests/Bootstrappers/BroadcastingConfigBootstrapperTest.php
View file

@ -205,20 +205,17 @@ test('tenant broadcast manager receives the custom driver creators of the centra
expect(array_keys(invade(app(BroadcastManager::class))->customCreators))->toEqualCanonicalizing($originalDrivers);
});
test('tenant broadcasters receive the channels from the broadcaster bound in central context', function(string $driver) {
test('tenant broadcasters receive the channels from the broadcaster bound in central context', function() {
config([
'tenancy.bootstrappers' => [BroadcastingConfigBootstrapper::class],
'broadcasting.default' => $driver,
'broadcasting.default' => 'testing',
'broadcasting.connections.testing.driver' => 'testing',
]);
if ($driver === 'custom') {
config(['broadcasting.connections.custom.driver' => 'custom']);
}
$tenant1 = Tenant::create();
$tenant2 = Tenant::create();
app(BroadcastManager::class)->extend($driver, fn($app, $config) => new TestingBroadcaster('testing'));
app(BroadcastManager::class)->extend('testing', fn() => new TestingBroadcaster('testing'));
$getCurrentChannelsFromBoundBroadcaster = fn() => array_keys(invade(app(BroadcasterContract::class))->channels);
$getCurrentChannelsThroughManager = fn() => array_keys(invade(app(BroadcastManager::class)->driver())->channels);
@ -245,12 +242,7 @@ test('tenant broadcasters receive the channels from the broadcaster bound in cen
expect($channel)
->toBeIn($getCurrentChannelsThroughManager())
->toBeIn($getCurrentChannelsFromBoundBroadcaster());
})->with([
'pusher',
'ably',
'reverb',
'custom',
]);
});
test('channels registered in tenant context persist within that context but do not leak into other contexts', function() {
config([