mirror of
https://github.com/archtechx/tenancy.git
synced 2026-06-20 22:04:02 +00:00
Add --skip-tenants option to HasTenantOptions (#1436)
Adds a --skip-tenants option to all tenant artisan commands (`tenants:run`, `tenants:migrate`, `tenants:rollback`, `tenants:seed`, `tenants:up`, `tenants:down`). The option is the complement of the existing `--tenants` option instead of specifying which tenants to include, you specify which to exclude. --------- Co-authored-by: Jimish Gamit <unique.jimish@gmail.com> Co-authored-by: Samuel Stancl <samuel@archte.ch> Co-authored-by: lukinovec <lukinovec@gmail.com>
This commit is contained in:
parent
dfb0e1ad66
commit
652bc987ce
3 changed files with 57 additions and 4 deletions
|
|
@ -17,7 +17,8 @@ class Run extends Command
|
||||||
protected $description = 'Run a command for tenant(s)';
|
protected $description = 'Run a command for tenant(s)';
|
||||||
|
|
||||||
protected $signature = 'tenants:run {commandname : The artisan command.}
|
protected $signature = 'tenants:run {commandname : The artisan command.}
|
||||||
{--tenants=* : The tenant(s) to run the command for. Default: all}';
|
{--tenants=* : The tenant(s) to run the command for. Default: all}
|
||||||
|
{--skip-tenants=* : The tenant(s) to skip}';
|
||||||
|
|
||||||
public function handle(): int
|
public function handle(): int
|
||||||
{
|
{
|
||||||
|
|
|
||||||
|
|
@ -10,7 +10,7 @@ use Stancl\Tenancy\Database\Concerns\PendingScope;
|
||||||
use Symfony\Component\Console\Input\InputOption;
|
use Symfony\Component\Console\Input\InputOption;
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* Adds 'tenants' and 'with-pending' options.
|
* Adds 'tenants', 'skip-tenants', and 'with-pending' options.
|
||||||
*/
|
*/
|
||||||
trait HasTenantOptions
|
trait HasTenantOptions
|
||||||
{
|
{
|
||||||
|
|
@ -18,6 +18,7 @@ trait HasTenantOptions
|
||||||
{
|
{
|
||||||
return array_merge([
|
return array_merge([
|
||||||
new InputOption('tenants', null, InputOption::VALUE_IS_ARRAY|InputOption::VALUE_OPTIONAL, 'The tenants to run this command for. Leave empty for all tenants', null),
|
new InputOption('tenants', null, InputOption::VALUE_IS_ARRAY|InputOption::VALUE_OPTIONAL, 'The tenants to run this command for. Leave empty for all tenants', null),
|
||||||
|
new InputOption('skip-tenants', null, InputOption::VALUE_IS_ARRAY|InputOption::VALUE_OPTIONAL, 'The tenants to skip when running this command', null),
|
||||||
new InputOption('with-pending', null, InputOption::VALUE_OPTIONAL, 'Include pending tenants in query if true/1, exclude if false/0. Defaults to the tenancy.pending.include_in_queries config value.'),
|
new InputOption('with-pending', null, InputOption::VALUE_OPTIONAL, 'Include pending tenants in query if true/1, exclude if false/0. Defaults to the tenancy.pending.include_in_queries config value.'),
|
||||||
], parent::getOptions());
|
], parent::getOptions());
|
||||||
}
|
}
|
||||||
|
|
@ -42,6 +43,9 @@ trait HasTenantOptions
|
||||||
->when($this->option('tenants'), function ($query) {
|
->when($this->option('tenants'), function ($query) {
|
||||||
$query->whereIn(tenancy()->model()->getTenantKeyName(), $this->option('tenants'));
|
$query->whereIn(tenancy()->model()->getTenantKeyName(), $this->option('tenants'));
|
||||||
})
|
})
|
||||||
|
->when($this->option('skip-tenants'), function ($query) {
|
||||||
|
$query->whereNotIn(tenancy()->model()->getTenantKeyName(), $this->option('skip-tenants'));
|
||||||
|
})
|
||||||
->when(tenancy()->model()::hasGlobalScope(PendingScope::class), function ($query) {
|
->when(tenancy()->model()::hasGlobalScope(PendingScope::class), function ($query) {
|
||||||
$includePending = $this->input->hasParameterOption('--with-pending')
|
$includePending = $this->input->hasParameterOption('--with-pending')
|
||||||
? filter_var($this->option('with-pending') ?? true, FILTER_VALIDATE_BOOLEAN)
|
? filter_var($this->option('with-pending') ?? true, FILTER_VALIDATE_BOOLEAN)
|
||||||
|
|
|
||||||
|
|
@ -515,3 +515,51 @@ test('migrate fresh command only deletes tenant databases if drop_tenant_databas
|
||||||
expect($tenantHasDatabase($tenant))->toBe($shouldHaveDBAfterMigrateFresh);
|
expect($tenantHasDatabase($tenant))->toBe($shouldHaveDBAfterMigrateFresh);
|
||||||
}
|
}
|
||||||
})->with([true, false]);
|
})->with([true, false]);
|
||||||
|
|
||||||
|
test('migrate commands can skip specified tenants', function (string $command) {
|
||||||
|
$tenant1 = Tenant::create();
|
||||||
|
$tenant2 = Tenant::create();
|
||||||
|
$tenant3 = Tenant::create();
|
||||||
|
|
||||||
|
pest()->artisan("{$command} --skip-tenants={$tenant1->getTenantKey()} --skip-tenants={$tenant2->getTenantKey()}");
|
||||||
|
|
||||||
|
tenancy()->initialize($tenant1);
|
||||||
|
|
||||||
|
expect(Schema::hasTable('users'))->toBeFalse();
|
||||||
|
|
||||||
|
tenancy()->initialize($tenant2);
|
||||||
|
|
||||||
|
expect(Schema::hasTable('users'))->toBeFalse();
|
||||||
|
|
||||||
|
tenancy()->initialize($tenant3);
|
||||||
|
|
||||||
|
expect(Schema::hasTable('users'))->toBeTrue();
|
||||||
|
})->with([
|
||||||
|
'tenants:migrate',
|
||||||
|
'tenants:migrate-fresh',
|
||||||
|
]);
|
||||||
|
|
||||||
|
test('run command can skip specified tenants', function () {
|
||||||
|
$tenant1 = Tenant::create()->getTenantKey();
|
||||||
|
$tenant2 = Tenant::create()->getTenantKey();
|
||||||
|
$tenant3 = Tenant::create()->getTenantKey();
|
||||||
|
|
||||||
|
pest()->artisan("tenants:run --skip-tenants=$tenant1 --skip-tenants=$tenant2 'bar foo foo@bar foobar arg --option=option'")
|
||||||
|
->doesntExpectOutputToContain("Tenant: $tenant1")
|
||||||
|
->doesntExpectOutputToContain("Tenant: $tenant2")
|
||||||
|
->expectsOutputToContain("Tenant: $tenant3")
|
||||||
|
->assertExitCode(0);
|
||||||
|
});
|
||||||
|
|
||||||
|
test('tenants and skip-tenants options can be used together', function () {
|
||||||
|
$tenant1 = Tenant::create()->getTenantKey();
|
||||||
|
$tenant2 = Tenant::create()->getTenantKey();
|
||||||
|
$tenant3 = Tenant::create()->getTenantKey();
|
||||||
|
|
||||||
|
// Scope to tenant1+tenant2, then skip tenant2 — only tenant1 should run
|
||||||
|
pest()->artisan("tenants:run --tenants=$tenant1 --tenants=$tenant2 --skip-tenants=$tenant2 'bar foo foo@bar foobar arg --option=option'")
|
||||||
|
->expectsOutputToContain("Tenant: $tenant1")
|
||||||
|
->doesntExpectOutputToContain("Tenant: $tenant2")
|
||||||
|
->doesntExpectOutputToContain("Tenant: $tenant3")
|
||||||
|
->assertExitCode(0);
|
||||||
|
});
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue