mirror of
https://github.com/archtechx/tenancy.git
synced 2026-05-06 15:24:03 +00:00
Make in-memory DB detection more strict
In-memory DBs have to start with "file:_tenancy_inmemory_". This prevents path traversal.
This commit is contained in:
parent
b1f0d0a43c
commit
7363318f6e
2 changed files with 8 additions and 4 deletions
|
|
@ -155,6 +155,6 @@ class SQLiteDatabaseManager implements TenantDatabaseManager
|
||||||
|
|
||||||
public static function isInMemory(string $name): bool
|
public static function isInMemory(string $name): bool
|
||||||
{
|
{
|
||||||
return $name === ':memory:' || str_contains($name, '_tenancy_inmemory_');
|
return $name === ':memory:' || str_starts_with($name, 'file:_tenancy_inmemory_');
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
|
||||||
|
|
@ -615,7 +615,7 @@ test('database managers validate parameters that cannot be bound', function ($dr
|
||||||
}
|
}
|
||||||
})->with('database_managers');
|
})->with('database_managers');
|
||||||
|
|
||||||
test('sqlite database manager validates database filenames', function () {
|
test('sqlite database manager validates database names', function () {
|
||||||
$manager = app(SQLiteDatabaseManager::class);
|
$manager = app(SQLiteDatabaseManager::class);
|
||||||
|
|
||||||
// Dots are allowed in database names
|
// Dots are allowed in database names
|
||||||
|
|
@ -630,9 +630,13 @@ test('sqlite database manager validates database filenames', function () {
|
||||||
expect(fn () => $manager->databaseExists(''))
|
expect(fn () => $manager->databaseExists(''))
|
||||||
->toThrow(InvalidArgumentException::class);
|
->toThrow(InvalidArgumentException::class);
|
||||||
|
|
||||||
// In-memory database names aren't validated
|
// In-memory database names have to start with 'file:_tenancy_inmemory_'
|
||||||
expect(fn () => $manager->databaseExists('../_tenancy_inmemory_'))
|
expect(fn () => $manager->databaseExists('file:_tenancy_inmemory_123?mode=memory&cache=shared'))
|
||||||
->not()->toThrow(InvalidArgumentException::class);
|
->not()->toThrow(InvalidArgumentException::class);
|
||||||
|
|
||||||
|
// Doesn't start with 'file:_tenancy_inmemory_', not considered an in-memory database, filename validation applies
|
||||||
|
expect(fn () => $manager->databaseExists('../_tenancy_inmemory_'))
|
||||||
|
->toThrow(InvalidArgumentException::class);
|
||||||
});
|
});
|
||||||
|
|
||||||
// Datasets
|
// Datasets
|
||||||
|
|
|
||||||
Loading…
Add table
Add a link
Reference in a new issue