Add test for tenancy.database.based_on null

assets/config.php

@@ -25,7 +25,7 @@ return [
         // 'localhost',
     ],
     'database' => [
-        'based_on' => null, // The connection that will be used as a base for the dynamically created tenant connection. // todo2 test this
+        'based_on' => null, // The connection that will be used as a base for the dynamically created tenant connection.
         'prefix' => 'tenant',
         'suffix' => '',
     ],

src/Commands/Migrate.php

@@ -56,7 +56,7 @@ class Migrate extends MigrateCommand
             // See Illuminate\Database\Migrations\DatabaseMigrationRepository::getConnection.
             // Database connections are cached by Illuminate\Database\ConnectionResolver.
             $this->input->setOption('database', 'tenant');
-            tenancy()->initialize($tenant); // todo2 test that this works with multiple tenants with MySQL
+            tenancy()->initialize($tenant);
 
             // Migrate
             parent::handle();

tests/DatabaseManagerTest.php

@@ -31,4 +31,19 @@ class DatabaseManagerTest extends TestCase
 
         $this->assertSame(config('database.connections.fooconn.database'), database_path('foodb'));
     }
+
+    /** @test */
+    public function the_default_db_is_used_when_based_on_is_null()
+    {
+        $this->assertSame('sqlite', config('database.default'));
+        config([
+            'database.connections.sqlite.foo' => 'bar',
+            'tenancy.database.based_on' => null,
+        ]);
+
+        tenancy()->init('test.localhost');
+
+        $this->assertSame('tenant', config('database.default'));
+        $this->assertSame('bar', config('database.connections.' . config('database.default') . '.foo'));
+    }
 }