[4.x] General code cleanup (#1278)

* Declare sensitive parameters as sensitive

... just so that they don't show up in logs

* Remove unnecessary null-coalescing

* Simplify return

* Merge isset() calls

* Inline return

* Use nullsafe operator

* Simplify if-else branches

* Use direct empty string comparison instead of strlen()

* Add missing type

* Change interface as events expect a TenantWithDatabase not just a Tenant

* Narrow typehint

* Remove redundant type casts

* Fix style with php-cs-fixer

* Fix typos

* Revert unwanted if-else simplification

* fix phpstan errors

* narrow type

---------

Co-authored-by: Samuel Štancl <samuel@archte.ch>

src/Controllers/TenantAssetController.php

@@ -88,12 +88,12 @@ class TenantAssetController implements HasMiddleware
             if (app()->runningUnitTests()) {
                 // Makes testing the cause of the failure in validatePath() easier
                 throw new Exception($exceptionMessage);
-            } else {
-                // We always use 404 to avoid leaking information about the cause of the error
-                // e.g. when someone is trying to access a nonexistent file outside of the allowed
-                // root folder, we don't want to let the user know whether such a file exists or not.
-                abort(404);
             }
+
+            // We always use 404 to avoid leaking information about the cause of the error
+            // e.g. when someone is trying to access a nonexistent file outside of the allowed
+            // root folder, we don't want to let the user know whether such a file exists or not.
+            abort(404);
         }
     }
 }