archtechx/tenancy
1
0
Fork 0
mirror of https://github.com/archtechx/tenancy.git synced 2025-12-12 22:14:03 +00:00
Code Activity

[4.x] General code cleanup (#1278)

Browse source 
* Declare sensitive parameters as sensitive

... just so that they don't show up in logs

* Remove unnecessary null-coalescing

* Simplify return

* Merge isset() calls

* Inline return

* Use nullsafe operator

* Simplify if-else branches

* Use direct empty string comparison instead of strlen()

* Add missing type

* Change interface as events expect a TenantWithDatabase not just a Tenant

* Narrow typehint

* Remove redundant type casts

* Fix style with php-cs-fixer

* Fix typos

* Revert unwanted if-else simplification

* fix phpstan errors

* narrow type

---------

Co-authored-by: Samuel Štancl <samuel@archte.ch>
This commit is contained in:
Márk Magyar 2024-12-31 00:35:46 +01:00 • committed by GitHub
parent 05b602e37f
commit 79f740d057
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
24 changed files with 45 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

4
src/Middleware/InitializeTenancyByPath.php
View file

@ -43,9 +43,9 @@ class InitializeTenancyByPath extends IdentificationMiddleware
$next,
$route
);
} else {
throw new RouteIsMissingTenantParameterException;
}
throw new RouteIsMissingTenantParameterException;
}
/**

4
src/Middleware/InitializeTenancyByRequestData.php
View file

@ -96,9 +96,7 @@ class InitializeTenancyByRequestData extends IdentificationMiddleware
if (
is_array($data) &&
isset($data['iv']) &&
isset($data['value']) &&
isset($data['mac'])
isset($data['iv'], $data['value'], $data['mac'])
) {
// We can confidently assert that the cookie is encrypted. If this call were to fail, this method would just
// return null and the cookie payload would get skipped.