archtechx/tenancy
1
0
Fork 0
mirror of https://github.com/archtechx/tenancy.git synced 2025-12-12 11:34:03 +00:00
Code Activity

get phpstan errors down from 252 to 189

Browse source
This commit is contained in:
Samuel Štancl 2022-08-30 05:44:23 +02:00
parent fb8b9c1614
commit 8af354c20e
40 changed files with 119 additions and 115 deletions
Download patch file Download diff file Expand all files Collapse all files

3
src/Tenancy.php
View file

@ -28,7 +28,7 @@ class Tenancy
public ?Closure $getBootstrappersUsing = null;
/** Is tenancy fully initialized? */
public $initialized = false; // todo document the difference between $tenant being set and $initialized being true (e.g. end of initialize() method)
public bool $initialized = false; // todo document the difference between $tenant being set and $initialized being true (e.g. end of initialize() method)
/** Initialize tenancy for the passed tenant. */
public function initialize(Tenant|int|string $tenant): void
@ -42,6 +42,7 @@ class Tenancy
}
}
// todo0 for phpstan this should be $this->tenant?, but first I want to clean up the $initialized logic and explore removing the property
if ($this->initialized && $this->tenant->getTenantKey() === $tenant->getTenantKey()) {
return;
}