archtechx/tenancy
1
0
Fork 0
mirror of https://github.com/archtechx/tenancy.git synced 2026-08-06 04:54:04 +00:00
Code Activity

Delete the redundant BroadcastingFactory::class arg from the Broadcast::clearResolvedInstance calls

Browse source 
Also in bootstrap(), update the clearResolvedInstance comment. Remove the FQCN mention and explain why exactly do we need to clear the resolved instance
This commit is contained in:
lukinovec 2026-07-10 11:07:30 +02:00
parent 9af173553e
commit 937c8c87d9
1 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

11
src/Bootstrappers/BroadcastingConfigBootstrapper.php
View file

@ -7,7 +7,6 @@ namespace Stancl\Tenancy\Bootstrappers;
use Illuminate\Broadcasting\BroadcastManager;
use Illuminate\Config\Repository;
use Illuminate\Contracts\Broadcasting\Broadcaster;
use Illuminate\Contracts\Broadcasting\Factory as BroadcastingFactory;
use Illuminate\Foundation\Application;
use Illuminate\Support\Facades\Broadcast;
use Stancl\Tenancy\Contracts\TenancyBootstrapper;
@ -103,10 +102,10 @@ class BroadcastingConfigBootstrapper implements TenancyBootstrapper
return $this->app->make(BroadcastManager::class)->connection();
});
// Clear the resolved Broadcast facade's Illuminate\Contracts\Broadcasting\Factory instance
// so that it gets re-resolved as TenancyBroadcastManager instead of the central BroadcastManager
// when used. E.g. the Broadcast::auth() call in BroadcastController::authenticate (/broadcasting/auth).
Broadcast::clearResolvedInstance(BroadcastingFactory::class);
// Extending the binding doesn't update the Broadcast facade's cached instance,
// so clear it to make the facade re-resolve to TenancyBroadcastManager instead of the central
// BroadcastManager — e.g. in the Broadcast::auth() call in BroadcastController (/broadcasting/auth).
Broadcast::clearResolvedInstance();
}
public function revert(): void
@ -116,7 +115,7 @@ class BroadcastingConfigBootstrapper implements TenancyBootstrapper
$this->app->singleton(Broadcaster::class, fn (Application $app) => $this->originalBroadcaster);
// Clear the resolved Broadcast facade instance so that it gets re-resolved as the central BroadcastManager
Broadcast::clearResolvedInstance(BroadcastingFactory::class);
Broadcast::clearResolvedInstance();
$this->unsetConfig();
}