archtechx/tenancy
1
0
Fork 0
mirror of https://github.com/archtechx/tenancy.git synced 2026-02-05 12:54:05 +00:00
Code Activity

Use consistent shortest path terminology

Browse source
This commit is contained in:
lukinovec 2025-05-29 13:13:41 +02:00
parent c867ecec44
commit a1e8324fb5
1 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

14
src/RLS/PolicyManagers/TableRLSManager.php
View file

@ -489,26 +489,26 @@ class TableRLSManager implements RLSPolicyManager
}
/**
* Determine if the passed path is better than the current shortest path.
* Determine if the passed path is preferred to the current shortest path.
*
* Non-nullable paths are preferred over nullable paths.
* Non-nullable paths are preferred to nullable paths.
* From paths of the same nullability, the shorter will be preferred.
*/
protected function determineBetterPath(array $path, array $currentBestPath): bool
protected function determineBetterPath(array $path, array $shortestPath): bool
{
if (! $currentBestPath) {
if (! $shortestPath) {
return true;
}
$pathIsNullable = $this->isPathNullable($path['steps']);
$bestPathIsNullable = $this->isPathNullable($currentBestPath['steps']);
$shortestPathIsNullable = $this->isPathNullable($shortestPath['steps']);
// Prefer non-nullable
if ($pathIsNullable !== $bestPathIsNullable) {
if ($pathIsNullable !== $shortestPathIsNullable) {
return ! $pathIsNullable;
}
// Prefer shorter
return count($path['steps']) < count($currentBestPath['steps']);
return count($path['steps']) < count($shortestPath['steps']);
}
}