From b437f64e3056a6f74a898be69ba6da1859d6b877 Mon Sep 17 00:00:00 2001 From: Abrar Ahmad Date: Mon, 29 Aug 2022 12:42:58 +0500 Subject: [PATCH] rename method to `getAttributesForCreation` --- src/Listeners/UpdateSyncedResource.php | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/Listeners/UpdateSyncedResource.php b/src/Listeners/UpdateSyncedResource.php index b11cad57..f13924e5 100644 --- a/src/Listeners/UpdateSyncedResource.php +++ b/src/Listeners/UpdateSyncedResource.php @@ -60,7 +60,7 @@ class UpdateSyncedResource extends QueueableListener event(new SyncedResourceChangedInForeignDatabase($event->model, null)); } else { // If the resource doesn't exist at all in the central DB,we create - $centralModel = $event->model->getCentralModelName()::create($this->getResourceCreationAttributes($event->model)); + $centralModel = $event->model->getCentralModelName()::create($this->getAttributesForCreation($event->model)); event(new SyncedResourceChangedInForeignDatabase($event->model, null)); } }); @@ -113,7 +113,7 @@ class UpdateSyncedResource extends QueueableListener $localModel->update($syncedAttributes); } else { // When creating, we use all columns, not just the synced ones. - $localModel = $localModelClass::create($this->getResourceCreationAttributes($eventModel)); + $localModel = $localModelClass::create($this->getAttributesForCreation($eventModel)); } event(new SyncedResourceChangedInForeignDatabase($localModel, $tenant)); @@ -121,13 +121,11 @@ class UpdateSyncedResource extends QueueableListener }); } - protected function getResourceCreationAttributes(Syncable $model): array + protected function getAttributesForCreation(Syncable $model): array { $attributes = $model->getAttributes(); if ($model->getResourceCreationAttributes()) { - // If function returned array is key-value, We assume default values are provided - // if array is plain values, fetch attributes from model $attributes = Arr::isAssoc($model->getResourceCreationAttributes()) ? $model->getResourceCreationAttributes() : $model->only($model->getResourceCreationAttributes()); }