From c8eb4a0de5b08ad7f940cafb38509a9b4c15d182 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Samuel=20=C5=A0tancl?= Date: Thu, 20 Feb 2025 14:33:51 +0100 Subject: [PATCH] resolve more todos --- assets/config.php | 10 ++++++++-- src/Bootstrappers/RootUrlBootstrapper.php | 9 ++------- 2 files changed, 10 insertions(+), 9 deletions(-) diff --git a/assets/config.php b/assets/config.php index e423e434..4c8870bc 100644 --- a/assets/config.php +++ b/assets/config.php @@ -213,7 +213,14 @@ return [ // 'pgsql' => Stancl\Tenancy\Database\TenantDatabaseManagers\PermissionControlledPostgreSQLSchemaManager::class, // Also permission controlled ], - // todo0 + /* + * Drop tenant databases when `php artisan migrate:fresh` is used. + * You may want to use this locally since deleting tenants only + * deletes their databases when they're deleted individually, not + * when the records are mass deleted from the database. + * + * Note: This overrides the default MigrateFresh command. + */ 'drop_tenant_databases_on_migrate_fresh' => false, ], @@ -402,7 +409,6 @@ return [ /** * Make all routes central, tenant, or universal by default. - * todo@earlyIdReview todo0 * * To override the default route mode, apply the middleware of another route mode ('central', 'tenant', 'universal') to the route. */ diff --git a/src/Bootstrappers/RootUrlBootstrapper.php b/src/Bootstrappers/RootUrlBootstrapper.php index b51f63e3..5958737c 100644 --- a/src/Bootstrappers/RootUrlBootstrapper.php +++ b/src/Bootstrappers/RootUrlBootstrapper.php @@ -36,13 +36,8 @@ class RootUrlBootstrapper implements TenancyBootstrapper protected string|null $originalRootUrl = null; /** - * You may want to selectively enable or disable this bootstrapper in specific tests. - * For instance, when using `Livewire::test()` this bootstrapper can cause problems, - * due to an internal Livewire route, so you may want to disable it, while in tests - * that are generating URLs in things like mails, the bootstrapper should be used - * just like in any queued job. - * - * todo0 update docblock + * Overriding the root url may cause issues in *some* tests, so you can disable + * the behavior by setting this property to false. */ public static bool $rootUrlOverrideInTests = true;