From e93e766f926d3851a68e50b72ffb843c90682e4e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Samuel=20=C5=A0tancl?= Date: Mon, 8 Jun 2020 21:35:41 +0200 Subject: [PATCH] Remove unnecessary typehints --- src/Contracts/Syncable.php | 2 +- src/Contracts/Tenant.php | 2 +- src/Database/Models/Tenant.php | 2 +- tests/ResourceSyncingTest.php | 4 ++-- tests/TenantModelTest.php | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Contracts/Syncable.php b/src/Contracts/Syncable.php index db8a7037..1f6e36e7 100644 --- a/src/Contracts/Syncable.php +++ b/src/Contracts/Syncable.php @@ -8,7 +8,7 @@ interface Syncable { public function getGlobalIdentifierKeyName(): string; - public function getGlobalIdentifierKey(): string; + public function getGlobalIdentifierKey(); public function getCentralModelName(): string; diff --git a/src/Contracts/Tenant.php b/src/Contracts/Tenant.php index e46d6ae9..477157cf 100644 --- a/src/Contracts/Tenant.php +++ b/src/Contracts/Tenant.php @@ -17,7 +17,7 @@ interface Tenant public function getTenantKeyName(): string; /** Get the value of the key used for identifying the tenant. */ - public function getTenantKey(): ?string; + public function getTenantKey(); /** Get the value of an internal key. */ public function getInternal(string $key); diff --git a/src/Database/Models/Tenant.php b/src/Database/Models/Tenant.php index d6e97c44..66123dda 100644 --- a/src/Database/Models/Tenant.php +++ b/src/Database/Models/Tenant.php @@ -37,7 +37,7 @@ class Tenant extends Model implements Contracts\Tenant return 'id'; } - public function getTenantKey(): ?string + public function getTenantKey() { return $this->getAttribute($this->getTenantKeyName()); } diff --git a/tests/ResourceSyncingTest.php b/tests/ResourceSyncingTest.php index 44b4b4ce..570448d1 100644 --- a/tests/ResourceSyncingTest.php +++ b/tests/ResourceSyncingTest.php @@ -603,7 +603,7 @@ class CentralUser extends Model implements SyncMaster return ResourceUser::class; } - public function getGlobalIdentifierKey(): string + public function getGlobalIdentifierKey() { return $this->getAttribute($this->getGlobalIdentifierKeyName()); } @@ -636,7 +636,7 @@ class ResourceUser extends Model implements Syncable protected $guarded = []; public $timestamps = false; - public function getGlobalIdentifierKey(): string + public function getGlobalIdentifierKey() { return $this->getAttribute($this->getGlobalIdentifierKeyName()); } diff --git a/tests/TenantModelTest.php b/tests/TenantModelTest.php index d42db5c5..7ff4ca1f 100644 --- a/tests/TenantModelTest.php +++ b/tests/TenantModelTest.php @@ -224,7 +224,7 @@ class AnotherTenant extends Model implements Contracts\Tenant return 'id'; } - public function getTenantKey(): string + public function getTenantKey() { return $this->getAttribute('id'); }