Improve route cloning action (#8)

* Allow cloning routes when only kernel identification is used, explicitly enable specific cloning modes

* Explicitly enable needed clone modes in tests, use "clone" instead of "reregister"

* Fix code style (php-cs-fixer)

* Use  "cloning" instead of "re-registration" in UniversalRouteTest

* Only clone routes using path identification

* Revert clone mode changes

* Fix code style (php-cs-fixer)

* Update comment

* Skip cloning 'stancl.tenancy.asset' by default

* Decide which routes should get cloned in the filtering step, improve method organization

* Return `RouteMode::UNIVERSAL` in getMiddlewareContext if route is universal

* Give universal route the path ID MW so that it gets cloned

* Fix code style (php-cs-fixer)

* Simplify UsableWithEarlyIdentification code

* Handle universal route mode in ForgetTenantParameter

* Fix code style (php-cs-fixer)

* Rename getMiddlewareContext to getRouteMode

* Append '/' to the route prefix

* Rename variable

* Wrap part of condition in parentheses

* Refresh name lookups after cloning routes

* Test giving tenant flag to cloned routes

* Add routeIsUniversal method

* Correct ForgetTenantParameter condition

* Improve tenant flag giving logic

* Improve test name

* Delete leftover testing code

* Put part of condition into `()`

* Improve CloneRoutesAsTenant code + comments

* Extract route mode-related code into methods, refactor and improve code

* Improve ForgetTenantParameter, test tenant parameter removing in universal routes

* Fix code style (php-cs-fixer)

* Fix test

* Simplify adding tenant flag

* Don't skip stancl.tenancy.asset route cloning

* clean up comment

* fix in_array() argument

* Fix code style (php-cs-fixer)

---------

Co-authored-by: PHP CS Fixer <phpcsfixer@example.com>
Co-authored-by: Samuel Štancl <samuel.stancl@gmail.com>

src/Middleware/InitializeTenancyByPath.php

@@ -76,15 +76,15 @@ class InitializeTenancyByPath extends IdentificationMiddleware implements Usable
     /**
      * Path identification request has a tenant if the middleware context is tenant.
      *
-     * With path identification, we can just check the MW context because we're re-registering the universal routes,
+     * With path identification, we can just check the MW context because we're cloning the universal routes,
      * and the routes are flagged with the 'tenant' MW group (= their MW context is tenant).
      *
      * With other identification middleware, we have to determine the context differently because we only have one
      * truly universal route available ('truly universal' because with path identification, applying 'universal' to a route just means that
-     * it should get re-registered, whereas with other ID MW, it means that the route you apply the 'universal' flag to will be accessible in both contexts).
+     * it should get cloned, whereas with other ID MW, it means that the route you apply the 'universal' flag to will be accessible in both contexts).
      */
     public function requestHasTenant(Request $request): bool
     {
-        return tenancy()->getMiddlewareContext(tenancy()->getRoute($request)) === RouteMode::TENANT;
+        return tenancy()->getRouteMode(tenancy()->getRoute($request)) === RouteMode::TENANT;
     }
 }

src/Middleware/PreventAccessFromUnwantedDomains.php

@@ -33,9 +33,8 @@ class PreventAccessFromUnwantedDomains
     public function handle(Request $request, Closure $next): mixed
     {
         $route = tenancy()->getRoute($request);
-        $routeIsUniversal = tenancy()->routeHasMiddleware($route, 'universal') || config('tenancy.default_route_mode') === RouteMode::UNIVERSAL;
 
-        if ($this->shouldBeSkipped($route) || $routeIsUniversal) {
+        if ($this->shouldBeSkipped($route) || tenancy()->routeIsUniversal($route)) {
             return $next($request);
         }
 
@@ -52,13 +51,13 @@ class PreventAccessFromUnwantedDomains
 
     protected function accessingTenantRouteFromCentralDomain(Request $request, Route $route): bool
     {
-        return tenancy()->getMiddlewareContext($route) === RouteMode::TENANT // Current route's middleware context is tenant
+        return tenancy()->getRouteMode($route) === RouteMode::TENANT // Current route's middleware context is tenant
             && $this->isCentralDomain($request); // The request comes from a domain that IS present in the configured `tenancy.central_domains`
     }
 
     protected function accessingCentralRouteFromTenantDomain(Request $request, Route $route): bool
     {
-        return tenancy()->getMiddlewareContext($route) === RouteMode::CENTRAL // Current route's middleware context is central
+        return tenancy()->getRouteMode($route) === RouteMode::CENTRAL // Current route's middleware context is central
             && ! $this->isCentralDomain($request); // The request comes from a domain that ISN'T present in the configured `tenancy.central_domains`
     }