Improve route cloning action (#8)

* Allow cloning routes when only kernel identification is used, explicitly enable specific cloning modes

* Explicitly enable needed clone modes in tests, use "clone" instead of "reregister"

* Fix code style (php-cs-fixer)

* Use  "cloning" instead of "re-registration" in UniversalRouteTest

* Only clone routes using path identification

* Revert clone mode changes

* Fix code style (php-cs-fixer)

* Update comment

* Skip cloning 'stancl.tenancy.asset' by default

* Decide which routes should get cloned in the filtering step, improve method organization

* Return `RouteMode::UNIVERSAL` in getMiddlewareContext if route is universal

* Give universal route the path ID MW so that it gets cloned

* Fix code style (php-cs-fixer)

* Simplify UsableWithEarlyIdentification code

* Handle universal route mode in ForgetTenantParameter

* Fix code style (php-cs-fixer)

* Rename getMiddlewareContext to getRouteMode

* Append '/' to the route prefix

* Rename variable

* Wrap part of condition in parentheses

* Refresh name lookups after cloning routes

* Test giving tenant flag to cloned routes

* Add routeIsUniversal method

* Correct ForgetTenantParameter condition

* Improve tenant flag giving logic

* Improve test name

* Delete leftover testing code

* Put part of condition into `()`

* Improve CloneRoutesAsTenant code + comments

* Extract route mode-related code into methods, refactor and improve code

* Improve ForgetTenantParameter, test tenant parameter removing in universal routes

* Fix code style (php-cs-fixer)

* Fix test

* Simplify adding tenant flag

* Don't skip stancl.tenancy.asset route cloning

* clean up comment

* fix in_array() argument

* Fix code style (php-cs-fixer)

---------

Co-authored-by: PHP CS Fixer <phpcsfixer@example.com>
Co-authored-by: Samuel Štancl <samuel.stancl@gmail.com>

tests/EarlyIdentificationTest.php

@@ -263,6 +263,14 @@ test('the tenant parameter is only removed from tenant routes when using path id
             ->middleware('tenant')
             ->name('tenant-route');
 
+        RouteFacade::get($pathIdentification ? '/universal-route' : '/universal-route/{tenant?}', [ControllerWithMiddleware::class, 'routeHasTenantParameter'])
+            ->middleware('universal')
+            ->name('universal-route');
+
+        /** @var CloneRoutesAsTenant */
+        $cloneRoutesAction = app(CloneRoutesAsTenant::class);
+        $cloneRoutesAction->handle();
+
         $tenant = Tenant::create();
         $tenantKey = $tenant->getTenantKey();
 
@@ -274,12 +282,24 @@ test('the tenant parameter is only removed from tenant routes when using path id
             // Tenant parameter is removed from tenant routes using kernel path identification (Stancl\Tenancy\Listeners\ForgetTenantParameter)
             $response = pest()->get($tenantKey . '/tenant-route')->assertOk();
             expect((bool) $response->getContent())->toBeFalse();
+
+            // The tenant parameter gets removed from the cloned universal route
+            $response = pest()->get($tenantKey . '/universal-route')->assertOk();
+            expect((bool) $response->getContent())->toBeFalse();
         } else {
             // Tenant parameter is not removed from tenant routes using other kernel identification MW
             $tenant->domains()->create(['domain' => $domain = $tenantKey . '.localhost']);
 
             $response = pest()->get("http://{$domain}/{$tenantKey}/tenant-route")->assertOk();
             expect((bool) $response->getContent())->toBeTrue();
+
+            // The tenant parameter does not get removed from the universal route when accessing it through the central domain
+            $response = pest()->get("http://localhost/universal-route/$tenantKey")->assertOk();
+            expect((bool) $response->getContent())->toBeTrue();
+
+            // The tenant parameter gets removed from the universal route when accessing it through the tenant domain
+            $response = pest()->get("http://{$domain}/universal-route")->assertOk();
+            expect((bool) $response->getContent())->toBeFalse();
         }
     } else {
         RouteFacade::middlewareGroup('tenant', [$pathIdentification ? InitializeTenancyByPath::class : InitializeTenancyByDomain::class]);
@@ -370,7 +390,7 @@ test('route level identification is prioritized over kernel identification', fun
     'default to central routes' => RouteMode::CENTRAL,
 ]);
 
-test('routes with path identification middleware can get prefixed using the reregister action', function() {
+test('routes with path identification middleware can get prefixed using the clone action', function() {
     $tenantKey = Tenant::create()->getTenantKey();
 
     RouteFacade::get('/home', fn () => tenant()?->getTenantKey())->name('home')->middleware(InitializeTenancyByPath::class);