lukinovec
d1f12f594d
Instead of assigning $innerMiddleware during group MW unpacking, merge it ( #1371 )
2025-07-01 17:23:13 +02:00
Márk Magyar
79f740d057
[4.x] General code cleanup ( #1278 )
...
* Declare sensitive parameters as sensitive
... just so that they don't show up in logs
* Remove unnecessary null-coalescing
* Simplify return
* Merge isset() calls
* Inline return
* Use nullsafe operator
* Simplify if-else branches
* Use direct empty string comparison instead of strlen()
* Add missing type
* Change interface as events expect a TenantWithDatabase not just a Tenant
* Narrow typehint
* Remove redundant type casts
* Fix style with php-cs-fixer
* Fix typos
* Revert unwanted if-else simplification
* fix phpstan errors
* narrow type
---------
Co-authored-by: Samuel Štancl <samuel@archte.ch>
2024-12-31 00:35:46 +01:00
lukinovec
cb0d7e2902
Improve early identification tests ( #66 )
...
* Separate route-level domain identification test from path/request to improve readability WIP
* Get rid of confusing datasets in route-level identifcation tests
* Clean up updated tests
* Simplify early id tests
* Reduce dataset duplication
* Improve test readability, fix false positive, polish details
* Separate early ID test from defaulting test (WIP)
* Finish improving and correcting the early identification/default route mode tests
* Make flag/default mode usage more clear by improving the docblock in DealsWithRouteContexts
* Fix PHPUnit deprecation warnings
* code review
* code review
---------
Co-authored-by: Samuel Štancl <samuel@archte.ch>
2024-12-20 03:42:23 +01:00
Samuel Štancl
b97c203967
Revert changes that caused issues with Laravel Octane [ci skip]
2024-04-24 22:36:51 +02:00
lukinovec
4e51cdbacb
Refactor early identification ( #47 )
...
* Make universal route logic part of tbe early ID trait
* Add requstHasTenant to prevent access MW, add todo@samuel
* Delete PathIdentificationManager, move the used methods appropriately
* Correct and refactor code related to the deleted PathIdentificationManager class
* Add docblock
* Fix code style (php-cs-fixer)
* refactor globalStackMiddleware()
* remove todos [ci skip]
* refactor routeMiddleware()
* revert bool assertions
* revert more changes
---------
Co-authored-by: PHP CS Fixer <phpcsfixer@example.com>
Co-authored-by: Samuel Štancl <samuel@archte.ch>
2024-04-22 11:30:58 +02:00
lukinovec
c312156c18
Give universal flag highest priority ( #27 )
...
* Give universal flag the highest priority (wip)
* Stop forgetting tenant parameter when route-level path ID is used
* Fix PHPStan errors
* Simplify annotation
* Fix comment
* Correct annotations
* Improve requestHasTenant comment
* Make cloning logic only clone universal routes, delete the universal flag from the new (tenant) route
* Delete APP_DEBUG
* make if condition easier to read
* Update DealsWithRouteContexts.php
* Fix test
* Fix code style (php-cs-fixer)
* Move tests
* Delete incorrectly committed file
* Cloning routes update wip
* Route cloning rework WIP
* Add todo to clone routes
* Fix code style (php-cs-fixer)
* Route cloning fix WIP
* Set CloneRoutesAsTenant::$tenantMiddleware to ID MW
* Revert CloneRoutesAsTenant::$tenantMiddleware-related changes
* Simplify requestHasTenant
* Add and test 'ckone' flag
* Delete setting $skippedRoutes from CloneRoutesAsTenant
* Fix code style (php-cs-fixer)
* make config key used for testing distinct from normal tenancy config keys
* Update src/Actions/CloneRoutesAsTenant.php
* Move 'path identification types' dataset to CloneActionTest
---------
Co-authored-by: Samuel Štancl <samuel.stancl@gmail.com>
Co-authored-by: Samuel Štancl <samuel@archte.ch>
Co-authored-by: PHP CS Fixer <phpcsfixer@example.com>
2024-01-25 15:27:17 +01:00
lukinovec
e4df597d81
Make providing identification middleware statically to controllers work ( #18 )
...
* Test identification with universal flag with statically provided MW
* Include statically provided controller MW in `tenancy()->getRouteMiddleware()`
* Fix code style (php-cs-fixer)
* Fix PHPStan error
* Test path ID MW and route cloning with statically provided MW
* Create validate.yml
* set continue-on-error to true
* change continue-on-error to fail-fast
* add job name and use if: always()
* update todo
* Update path identification and Fortify integration-related logic (#13 )
* Add commented UrlBinding + FortifyRouteTenancy bootstrappers to the config
* Improve FortifyRoute bootstrapper docblock
* Rename bootstrappers
* Complete renaming
* Pass defaults of the original URL generator to the new one
* Fix URL generator-related test (query string id test WIP)
* Fix code style (php-cs-fixer)
* Make Fortify bootstrapper not depend on the UrlGenerator bootstrapper, update comments
* Fix testing UrlGenerator bootstrapper
* Update TenancyUrlGenerator annotations
* Pass tenant parameter manually in Fortify bootstrapper
* Properly test TenancyUrlGenerator functionality
* Get rid of query string in Fortify bootstrapper
* Fix code style (php-cs-fixer)
* Delete outdated comment
* Improve comment
* Improve before/afterEach
* Encourage passing parameters using TenancyUrlGenerator instead of URL::defaults()
* Delete rest of defaulting logic
* Fix code style (php-cs-fixer)
* Delete test group
* Update ForgetTenantParameter docblock
* Update passTenantParameterToRoutes annotation
* Complete todo in test
* Improve test
* Update comment
* Improve comment
* Add keepQueryParameters bool to Fortify bootstrapper
* Test keepQueryParameters
* minor docblock update
* minor docblock changes
* Delete extra import
* Update src/Overrides/TenancyUrlGenerator.php
Co-authored-by: Samuel Štancl <samuel.stancl@gmail.com>
* Improve comment
* Rename test
* Update bypass parameter-related test comments
* Fix merge
* Rename $keepQueryParameters
* Add docblock
* Add comment
* Refactor Fortify bootstrapper
* Fix code style (php-cs-fixer)
* Fix comment
* Skip Fortify bootstrapper test
* minor code improvements
* Improve fortify bootstrapper test
* Add Fortify bootstrapper annotation, improve code
* Fix code style (php-cs-fixer)
* Add commenet
* Complete resource syncing todo (cleanup not needed)
* Delete incorrect namespace
* Complete route context trait name todo
* Fix code style (php-cs-fixer)
---------
Co-authored-by: PHP CS Fixer <phpcsfixer@example.com>
Co-authored-by: Samuel Štancl <samuel.stancl@gmail.com>
* Include statically provided controller MW in `tenancy()->getRouteMiddleware()`
* Fix code style (php-cs-fixer)
* Improve PHPStan error fix
* Include statically provided controller MW in `tenancy()->getRouteMiddleware()`
* Fix PHPStan error
* Fix code style (php-cs-fixer)
* Include statically provided controller MW in `tenancy()->getRouteMiddleware()`
* Fix code style (php-cs-fixer)
---------
Co-authored-by: PHP CS Fixer <phpcsfixer@example.com>
Co-authored-by: Samuel Štancl <samuel.stancl@gmail.com>
2023-12-01 09:38:43 +01:00
lukinovec
4953c69fd8
Update path identification and Fortify integration-related logic ( #13 )
...
* Add commented UrlBinding + FortifyRouteTenancy bootstrappers to the config
* Improve FortifyRoute bootstrapper docblock
* Rename bootstrappers
* Complete renaming
* Pass defaults of the original URL generator to the new one
* Fix URL generator-related test (query string id test WIP)
* Fix code style (php-cs-fixer)
* Make Fortify bootstrapper not depend on the UrlGenerator bootstrapper, update comments
* Fix testing UrlGenerator bootstrapper
* Update TenancyUrlGenerator annotations
* Pass tenant parameter manually in Fortify bootstrapper
* Properly test TenancyUrlGenerator functionality
* Get rid of query string in Fortify bootstrapper
* Fix code style (php-cs-fixer)
* Delete outdated comment
* Improve comment
* Improve before/afterEach
* Encourage passing parameters using TenancyUrlGenerator instead of URL::defaults()
* Delete rest of defaulting logic
* Fix code style (php-cs-fixer)
* Delete test group
* Update ForgetTenantParameter docblock
* Update passTenantParameterToRoutes annotation
* Complete todo in test
* Improve test
* Update comment
* Improve comment
* Add keepQueryParameters bool to Fortify bootstrapper
* Test keepQueryParameters
* minor docblock update
* minor docblock changes
* Delete extra import
* Update src/Overrides/TenancyUrlGenerator.php
Co-authored-by: Samuel Štancl <samuel.stancl@gmail.com>
* Improve comment
* Rename test
* Update bypass parameter-related test comments
* Fix merge
* Rename $keepQueryParameters
* Add docblock
* Add comment
* Refactor Fortify bootstrapper
* Fix code style (php-cs-fixer)
* Fix comment
* Skip Fortify bootstrapper test
* minor code improvements
* Improve fortify bootstrapper test
* Add Fortify bootstrapper annotation, improve code
* Fix code style (php-cs-fixer)
* Add commenet
* Complete resource syncing todo (cleanup not needed)
* Delete incorrect namespace
* Complete route context trait name todo
* Fix code style (php-cs-fixer)
---------
Co-authored-by: PHP CS Fixer <phpcsfixer@example.com>
Co-authored-by: Samuel Štancl <samuel.stancl@gmail.com>
2023-11-26 21:08:41 +01:00
