mirror of
https://github.com/archtechx/tenancy.git
synced 2026-08-06 04:54:04 +00:00
04da9c896b
> Minor breaking change: clearing pending_since no longer fires Eloquent events, PullingPendingTenant is now fired at a different point in the lifecycle and does not guarantee the tenant will actually be pulled. `pullPendingFromPool` had a race condition when user A attempted to pull a tenant at the same time as user B. Both could end up grabbing the same tenant, and the result was unexpected, e.g. one of them ending up with no pending tenant pulled at all even though there was a pending tenant in the pool. instead of selecting a pending tenant and updating the same model, we now run `update()` conditionally -- it clears `pending_since` _only_ if the tenant is still pending, and we check the affected row count. Only one process can get a row back, the other gets 0 and retries with the next pending candidate in the pool. The loop always terminates since every lost claim means the pool shrank by one. Eventually it's empty and we create a new tenant (or return null). The claim and the attribute update happen in a single transaction now, so if updating `$attributes` fails, the claim rolls back and the tenant stays in the pool. Added a regression test that simulates a concurrent "steal" synchronously via a PullingPendingTenant listener. Fails with the old code, passes with the HasPending changes. Very minor BC: - Clearing `pending_since` no longer fires model updating/updated events (since the update goes through query builder). `PendingTenantPulled` still fires the same as before and is the listener you'd want to use anyway. - `PullingPendingTenant` now fires before the claim (and outside the transaction), so it can fire more than once with concurrent pulls (e.g. when a tenant gets claimed by someone else). `PendingTenantPulled` is still the one that fires exactly once for the actually pulled tenant. --------- Co-authored-by: Samuel Stancl <samuel@archte.ch> |
||
|---|---|---|
| .. | ||
| Bootstrappers | ||
| Etc | ||
| Features | ||
| RLS | ||
| ActionTest.php | ||
| AutomaticModeTest.php | ||
| BroadcastingTest.php | ||
| CachedTenantResolverTest.php | ||
| CloneActionTest.php | ||
| CombinedDomainAndSubdomainIdentificationTest.php | ||
| CommandsTest.php | ||
| DatabaseCacheBootstrapperTest.php | ||
| DatabasePreparationTest.php | ||
| DatabaseUsersTest.php | ||
| DeleteDomainsJobTest.php | ||
| DomainTest.php | ||
| EarlyIdentificationTest.php | ||
| EventListenerTest.php | ||
| GlobalCacheTest.php | ||
| InitializedBootstrappersTest.php | ||
| MailTest.php | ||
| MaintenanceModeTest.php | ||
| ManualModeTest.php | ||
| OriginHeaderIdentificationTest.php | ||
| PathIdentificationTest.php | ||
| PendingTenantsTest.php | ||
| Pest.php | ||
| PreventAccessFromUnwantedDomainsTest.php | ||
| QueueTest.php | ||
| RequestDataIdentificationTest.php | ||
| ResourceSyncingTest.php | ||
| RouteMiddlewareTest.php | ||
| RunForMultipleTest.php | ||
| ScopeSessionsTest.php | ||
| SessionSeparationTest.php | ||
| SingleDatabaseTenancyTest.php | ||
| SingleDomainTenantTest.php | ||
| SubdomainTest.php | ||
| TenantAssetTest.php | ||
| TenantAwareCommandTest.php | ||
| TenantDatabaseManagerTest.php | ||
| TenantModelTest.php | ||
| TenantUserImpersonationTest.php | ||
| TestCase.php | ||
| UniversalRouteTest.php | ||