mirror of
https://github.com/archtechx/tenancy.git
synced 2026-06-21 01:34:04 +00:00
da7eb94c07
The PreventAcessFromUnwantedDomains MW had the `tenancy()->routeIsUniversal($route)` check either for returning early, or it was a leftover from some older implementation, so I removed it. The middleware aborts if the `$this->accessingTenantRouteFromCentralDomain($request, $route) || $this->accessingCentralRouteFromTenantDomain($request, $route)` check passes. Meaning, **for the middleware to abort, the route has to be either in central or tenant mode**. When the route is in universal mode, the middleware will never reach `return $abortRequest()`. `return $next($request)` will always get reached, even when the `|| tenancy()->routeIsUniversal($route)` check is deleted from the previous condition, so that check was basically useless. Since the docblock for the class does mention the behavior for universal routes explicitly, we've instead added a comment documenting that things work this way. That's probably the most reasonable way to have this explicit behavior for universal routes easily understandable in this fairly complex logic without redundant code. Resolves #1418 --------- Co-authored-by: Samuel Štancl <samuel@archte.ch> |
||
|---|---|---|
| .. | ||
| CheckTenantForMaintenanceMode.php | ||
| IdentificationMiddleware.php | ||
| InitializeTenancyByDomain.php | ||
| InitializeTenancyByDomainOrSubdomain.php | ||
| InitializeTenancyByOriginHeader.php | ||
| InitializeTenancyByPath.php | ||
| InitializeTenancyByRequestData.php | ||
| InitializeTenancyBySubdomain.php | ||
| PreventAccessFromUnwantedDomains.php | ||
| ScopeSessions.php | ||