mirror of
https://github.com/archtechx/tenancy.git
synced 2026-08-06 04:54:04 +00:00
aa9d1d7fcf
### Parameter validation In `statement()` calls of `TenantDatabaseManager`s, use parameter binding when possible. When that's not possible, validate the parameters using `validateParameter()` or `validatePassword()`. Passwords use a less strict allowlist than other parameters (e.g. DB names), since passwords tend to use more special characters but we can afford to be more restrictive in the generic `validateParameter()`. In `SQLiteDatabaseManager`, names of file-based databases are validated (in `createDatabase`, `deleteDatabase` and `databaseExists`) using a similar allowlist to the (non-password) parameters in other DB managers, with an additional character: `.` (this addition is necessary since file-based SQLite databases end with `.sqlite`). ### DatabaseTenancyBootstrapper - harden() and the lost test file While checking for more places that could use validation, I realized that it's possible to update tenant's db_name to the central DB or the DB of another tenant. Added the `DatabaseTenancyBootstrapper::$harden` property -- setting it to true prevents tenants from connecting to the wrong databases (`RuntimeException` is thrown after connecting to the wrong database). Also, the DatabaseTenancyBootstrapper test file was ignored while running tests because it lacked the `Test` suffix. Added the suffix and fixed the broken `DATABASE_URL` test in the file. ### SQLiteDatabaseManager - respect static $path property in makeConnectionConfig() SQLiteDatabaseManager had a bug in `makeConnectionConfig`: the method didn't respect the static `$path` property, it used `database_path()` instead. Added a regression test for that. Also recognizing in-memory SQLite databases (using `isInMemory()`) is more strict now so that simply having a db_name with `_tenancy_inmemory_` somewhere in the name doesn't make a file-based database considered in-memory. ### MySQLDatabaseManager - charset and collation defaulting Creating databases with `null` charsets and collations resulted in a `QueryException`, since null isn't a valid charset/collation. To solve that, in the `CREATE DATABASE` statement in MySQLDatabaseManager, only add charset/collation to the statement if they are not null. MySQL defaults to the server's charset and collation, so it's safe to not pass any charset/collation in the `CREATE DATABASE` statement and let MySQL choose. Also, if e.g. collation is non-null and charset is null, MySQL will use a charset compatible with the used collation, and this works both ways. --------- Co-authored-by: Samuel Stancl <samuel@archte.ch> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> |
||
|---|---|---|
| .. | ||
| Bootstrappers | ||
| Etc | ||
| Features | ||
| RLS | ||
| ActionTest.php | ||
| AutomaticModeTest.php | ||
| BroadcastingTest.php | ||
| CachedTenantResolverTest.php | ||
| CloneActionTest.php | ||
| CombinedDomainAndSubdomainIdentificationTest.php | ||
| CommandsTest.php | ||
| DatabaseCacheBootstrapperTest.php | ||
| DatabasePreparationTest.php | ||
| DatabaseUsersTest.php | ||
| DeleteDomainsJobTest.php | ||
| DomainTest.php | ||
| EarlyIdentificationTest.php | ||
| EventListenerTest.php | ||
| GlobalCacheTest.php | ||
| InitializedBootstrappersTest.php | ||
| MailTest.php | ||
| MaintenanceModeTest.php | ||
| ManualModeTest.php | ||
| OriginHeaderIdentificationTest.php | ||
| PathIdentificationTest.php | ||
| PendingTenantsTest.php | ||
| Pest.php | ||
| PreventAccessFromUnwantedDomainsTest.php | ||
| QueueTest.php | ||
| RequestDataIdentificationTest.php | ||
| ResourceSyncingTest.php | ||
| RouteMiddlewareTest.php | ||
| RunForMultipleTest.php | ||
| ScopeSessionsTest.php | ||
| SessionSeparationTest.php | ||
| SingleDatabaseTenancyTest.php | ||
| SingleDomainTenantTest.php | ||
| SubdomainTest.php | ||
| TenantAssetTest.php | ||
| TenantAwareCommandTest.php | ||
| TenantDatabaseManagerTest.php | ||
| TenantModelTest.php | ||
| TenantUserImpersonationTest.php | ||
| TestCase.php | ||
| UniversalRouteTest.php | ||