mirror of
https://github.com/archtechx/tenancy.git
synced 2025-12-12 22:14:03 +00:00
* Test that route model binding works with path identification (closure-based routes) * Correct test name * Update tests/PathIdentificationTest.php Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> * make assertions more clear --------- Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> Co-authored-by: Samuel Štancl <samuel@archte.ch>
297 lines
11 KiB
PHP
297 lines
11 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use Illuminate\Contracts\Http\Kernel;
|
|
use Illuminate\Database\QueryException;
|
|
use Illuminate\Database\Schema\Blueprint;
|
|
use Illuminate\Routing\Middleware\SubstituteBindings;
|
|
use Illuminate\Support\Facades\Route;
|
|
use Illuminate\Support\Facades\Schema;
|
|
use Illuminate\Support\Facades\Event;
|
|
use Stancl\Tenancy\Exceptions\RouteIsMissingTenantParameterException;
|
|
use Stancl\Tenancy\Exceptions\TenantColumnNotWhitelistedException;
|
|
use Stancl\Tenancy\Exceptions\TenantCouldNotBeIdentifiedByPathException;
|
|
use Stancl\Tenancy\Middleware\InitializeTenancyByPath;
|
|
use Stancl\Tenancy\Resolvers\PathTenantResolver;
|
|
use Stancl\Tenancy\Tests\Etc\Tenant;
|
|
use Stancl\Tenancy\Events\TenantCreated;
|
|
use Stancl\Tenancy\Jobs\CreateDatabase;
|
|
use Stancl\Tenancy\Jobs\MigrateDatabase;
|
|
use Stancl\JobPipeline\JobPipeline;
|
|
use Stancl\Tenancy\Events\TenancyInitialized;
|
|
use Stancl\Tenancy\Listeners\BootstrapTenancy;
|
|
use Stancl\Tenancy\Listeners\RevertToCentralContext;
|
|
use Stancl\Tenancy\Tests\Etc\User;
|
|
use Stancl\Tenancy\Bootstrappers\DatabaseTenancyBootstrapper;
|
|
use Stancl\Tenancy\Events\TenancyEnded;
|
|
|
|
use function Stancl\Tenancy\Tests\pest;
|
|
|
|
beforeEach(function () {
|
|
// Make sure the tenant parameter is set to 'tenant'
|
|
config(['tenancy.identification.resolvers.' . PathTenantResolver::class . '.tenant_parameter_name' => 'tenant']);
|
|
|
|
InitializeTenancyByPath::$onFail = null;
|
|
Tenant::$extraCustomColumns = [];
|
|
|
|
Route::group([
|
|
'prefix' => '/{tenant}',
|
|
'middleware' => InitializeTenancyByPath::class,
|
|
], function () {
|
|
Route::get('/foo/{a}/{b}', function ($a, $b) {
|
|
return "$a + $b";
|
|
})->name('foo');
|
|
|
|
Route::get('/baz/{a}/{b}', function ($a, $b) {
|
|
return "$a - $b";
|
|
})->name('baz');
|
|
});
|
|
});
|
|
|
|
afterEach(function () {
|
|
InitializeTenancyByPath::$onFail = null;
|
|
Tenant::$extraCustomColumns = [];
|
|
});
|
|
|
|
test('tenant can be identified by path', function () {
|
|
Tenant::create([
|
|
'id' => 'acme',
|
|
]);
|
|
|
|
expect(tenancy()->initialized)->toBeFalse();
|
|
|
|
pest()->get('/acme/foo/abc/xyz');
|
|
|
|
expect(tenancy()->initialized)->toBeTrue();
|
|
expect(tenant('id'))->toBe('acme');
|
|
});
|
|
|
|
test('route actions dont get the tenant id', function () {
|
|
Tenant::create([
|
|
'id' => 'acme',
|
|
]);
|
|
|
|
expect(tenancy()->initialized)->toBeFalse();
|
|
|
|
pest()
|
|
->get('/acme/foo/abc/xyz')
|
|
->assertContent('abc + xyz');
|
|
|
|
expect(tenancy()->initialized)->toBeTrue();
|
|
expect(tenant('id'))->toBe('acme');
|
|
});
|
|
|
|
test('exception is thrown when tenant cannot be identified by path', function () {
|
|
pest()->expectException(TenantCouldNotBeIdentifiedByPathException::class);
|
|
|
|
$this
|
|
->withoutExceptionHandling()
|
|
->get('/acme/foo/abc/xyz');
|
|
|
|
expect(tenancy()->initialized)->toBeFalse();
|
|
});
|
|
|
|
test('onfail logic can be customized', function () {
|
|
InitializeTenancyByPath::$onFail = function () {
|
|
return response('foo');
|
|
};
|
|
|
|
pest()
|
|
->get('/acme/foo/abc/xyz')
|
|
->assertContent('foo');
|
|
|
|
InitializeTenancyByPath::$onFail = null;
|
|
});
|
|
|
|
test('an exception is thrown when the route does not have the tenant parameter', function () {
|
|
Route::group([
|
|
// 'prefix' => '/{tenant}', -- intentionally commented
|
|
'middleware' => InitializeTenancyByPath::class,
|
|
], function () {
|
|
Route::get('/bar/{a}/{b}', function ($a, $b) {
|
|
return "$a + $b";
|
|
});
|
|
});
|
|
|
|
Tenant::create([
|
|
'id' => 'acme',
|
|
]);
|
|
|
|
pest()->expectException(RouteIsMissingTenantParameterException::class);
|
|
|
|
$this
|
|
->withoutExceptionHandling()
|
|
->get('/bar/foo/bar');
|
|
});
|
|
|
|
test('tenant parameter name can be customized', function () {
|
|
config(['tenancy.identification.resolvers.' . PathTenantResolver::class . '.tenant_parameter_name' => 'team']);
|
|
|
|
Route::group([
|
|
'prefix' => '/{team}',
|
|
'middleware' => InitializeTenancyByPath::class,
|
|
], function () {
|
|
Route::get('/bar/{a}/{b}', function ($a, $b) {
|
|
return "$a + $b";
|
|
});
|
|
});
|
|
|
|
Tenant::create([
|
|
'id' => 'acme',
|
|
]);
|
|
|
|
pest()
|
|
->get('/acme/bar/abc/xyz')
|
|
->assertContent('abc + xyz');
|
|
|
|
// Parameter for resolver is changed, so the /{tenant}/foo route will no longer work.
|
|
pest()->expectException(RouteIsMissingTenantParameterException::class);
|
|
|
|
$this
|
|
->withoutExceptionHandling()
|
|
->get('/acme/foo/abc/xyz');
|
|
});
|
|
|
|
test('tenant parameter does not have to be the first in order to initialize tenancy', function() {
|
|
Tenant::create([
|
|
'id' => $tenantId = 'another-tenant',
|
|
]);
|
|
|
|
Route::get('/another/route/{a}/{tenant}/{b}', function ($a, $b) {
|
|
return "$a + $b + " . tenant()->getTenantKey();
|
|
})->middleware(InitializeTenancyByPath::class)->name('tenant-parameter-is-second');
|
|
|
|
pest()->get("/another/route/foo/$tenantId/bar")->assertSee("foo + bar + $tenantId");
|
|
});
|
|
|
|
test('central route can have a parameter with the same name as the tenant parameter', function() {
|
|
config(['tenancy.identification.resolvers.' . PathTenantResolver::class . '.tenant_parameter_name' => 'team']);
|
|
$tenantKey = Tenant::create()->getTenantKey();
|
|
|
|
// The route is flagged as central (while using kernel identification) so the {team} parameter should not be used for tenancy initialization
|
|
Route::get('/central/route/{team}/{a}/{b}', function ($team, $a, $b) {
|
|
return "$a + $b + $team";
|
|
})->middleware('central')->name('central-route');
|
|
|
|
pest()->get("/central/route/{$tenantKey}/foo/bar")->assertSee("foo + bar + {$tenantKey}");
|
|
|
|
expect(tenancy()->initialized)->toBeFalse();
|
|
|
|
// With kernel path identification
|
|
app(Kernel::class)->pushMiddleware(InitializeTenancyByPath::class);
|
|
|
|
pest()->get("/central/route/{$tenantKey}/foo/bar")->assertSee("foo + bar + {$tenantKey}");
|
|
|
|
expect(tenancy()->initialized)->toBeFalse();
|
|
});
|
|
|
|
test('the tenant model column can be customized in the config', function () {
|
|
config(['tenancy.identification.resolvers.' . PathTenantResolver::class . '.tenant_model_column' => 'slug']);
|
|
Tenant::$extraCustomColumns = ['slug'];
|
|
|
|
Schema::table('tenants', function (Blueprint $table) {
|
|
$table->string('slug')->unique();
|
|
});
|
|
|
|
$tenant = Tenant::create([
|
|
'slug' => 'acme',
|
|
]);
|
|
|
|
Route::get('/{tenant}/foo', function () {
|
|
return tenant()->getTenantKey();
|
|
})->middleware(InitializeTenancyByPath::class);
|
|
|
|
$this->withoutExceptionHandling();
|
|
pest()->get('/acme/foo')->assertSee($tenant->getTenantKey());
|
|
expect(fn () => pest()->get($tenant->id . '/foo'))->toThrow(TenantCouldNotBeIdentifiedByPathException::class);
|
|
});
|
|
|
|
test('the tenant model column can be customized in the route definition', function () {
|
|
Tenant::$extraCustomColumns = ['slug'];
|
|
config(['tenancy.identification.resolvers.' . PathTenantResolver::class . '.allowed_extra_model_columns' => ['slug']]);
|
|
|
|
Schema::table('tenants', function (Blueprint $table) {
|
|
$table->string('slug')->unique();
|
|
});
|
|
|
|
$tenant = Tenant::create([
|
|
'slug' => 'acme',
|
|
]);
|
|
|
|
Route::get('/{tenant}/foo', function () {
|
|
return tenant()->getTenantKey();
|
|
})->middleware(InitializeTenancyByPath::class);
|
|
|
|
Route::get('/{tenant:slug}/bar', function () {
|
|
return tenant()->getTenantKey();
|
|
})->middleware(InitializeTenancyByPath::class);
|
|
|
|
$this->withoutExceptionHandling();
|
|
|
|
// No binding field defined
|
|
pest()->get($tenant->getTenantKey() . '/foo')->assertSee($tenant->getTenantKey());
|
|
expect(fn () => pest()->get('/acme/foo'))->toThrow(TenantCouldNotBeIdentifiedByPathException::class);
|
|
|
|
// Binding field defined
|
|
pest()->get('/acme/bar')->assertSee($tenant->getTenantKey());
|
|
expect(fn () => pest()->get($tenant->id . '/bar'))->toThrow(TenantCouldNotBeIdentifiedByPathException::class);
|
|
});
|
|
|
|
test('any extra model column needs to be whitelisted', function () {
|
|
Tenant::$extraCustomColumns = ['slug'];
|
|
|
|
Schema::table('tenants', function (Blueprint $table) {
|
|
$table->string('slug')->unique();
|
|
});
|
|
|
|
$tenant = Tenant::create([
|
|
'slug' => 'acme',
|
|
]);
|
|
|
|
Route::get('/{tenant:slug}/foo', function () {
|
|
return tenant()->getTenantKey();
|
|
})->middleware(InitializeTenancyByPath::class);
|
|
|
|
$this->withoutExceptionHandling();
|
|
expect(fn () => pest()->get('/acme/foo'))->toThrow(TenantColumnNotWhitelistedException::class);
|
|
|
|
// After whitelisting the column it works
|
|
config(['tenancy.identification.resolvers.' . PathTenantResolver::class . '.allowed_extra_model_columns' => ['slug']]);
|
|
pest()->get('/acme/foo')->assertSee($tenant->getTenantKey());
|
|
});
|
|
|
|
test('route model binding works with path identification', function() {
|
|
config(['tenancy.bootstrappers' => [DatabaseTenancyBootstrapper::class]]);
|
|
|
|
Event::listen(TenancyInitialized::class, BootstrapTenancy::class);
|
|
Event::listen(TenantCreated::class, JobPipeline::make([
|
|
CreateDatabase::class, MigrateDatabase::class,
|
|
])->send(fn (TenantCreated $event) => $event->tenant)->toListener());
|
|
Event::listen(TenancyEnded::class, RevertToCentralContext::class);
|
|
|
|
$tenant = Tenant::create();
|
|
|
|
$this->withoutExceptionHandling();
|
|
|
|
// Importantly, the route must have the 'web' middleware group, or SubstituteBindings directly
|
|
Route::get('/{tenant}/foo/{user}', fn (User $user) => $user->name)->middleware([InitializeTenancyByPath::class, 'web']);
|
|
Route::get('/{tenant}/bar/{user}', fn (User $user) => $user->name)->middleware([InitializeTenancyByPath::class, SubstituteBindings::class]);
|
|
|
|
$user = $tenant->run(fn () => User::create(['name' => 'John Doe', 'email' => 'john@doe.com', 'password' => 'foobar']));
|
|
|
|
pest()->get("/{$tenant->id}/foo/{$user->id}")->assertSee("John Doe");
|
|
tenancy()->end();
|
|
pest()->get("/{$tenant->id}/bar/{$user->id}")->assertSee("John Doe");
|
|
tenancy()->end();
|
|
|
|
// If SubstituteBindings comes BEFORE tenancy middleware and middleware priority is not set, route model binding is NOT expected to work correctly
|
|
// Since SubstituteBindings runs first, it tries to query the central database instead of the tenant database (which fails with a QueryException in this case)
|
|
Route::get('/{tenant}/baz/{user}', fn (User $user) => $user->name ?: 'No user')->middleware([SubstituteBindings::class, InitializeTenancyByPath::class]);
|
|
expect(fn () => pest()->get("/{$tenant->id}/baz/{$user->id}"))->toThrow(QueryException::class);
|
|
tenancy()->end();
|
|
|
|
// If SubstituteBindings is NOT USED AT ALL, we simply get an empty User instance
|
|
Route::get('/{tenant}/xyz/{user}', fn (User $user) => $user->name ?: 'No user')->middleware([InitializeTenancyByPath::class]);
|
|
pest()->get("/{$tenant->id}/xyz/{$user->id}")->assertSee('No user');
|
|
});
|