archtechx/virtualcolumn
1
0
Fork 0
mirror of https://github.com/archtechx/virtualcolumn.git synced 2025-12-12 14:14:05 +00:00
Code Activity

Throw exception if a user is trying to overwrite the data without first loading it

Browse source
This commit is contained in:
Nick Potts 2024-04-09 07:18:43 +08:00
parent 9cda7d498c
commit 5426e41a5c
2 changed files with 25 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

13
src/VirtualColumn.php
View file

@ -31,9 +31,11 @@ trait VirtualColumn
*/
public bool $dataEncoded = false;
public bool $dataNotLoaded = false;
protected function decodeVirtualColumn(): void
{
if (! $this->dataEncoded) {
if (! $this->dataEncoded || ! $this->dataNotLoaded) {
return;
}
@ -65,6 +67,10 @@ trait VirtualColumn
return;
}
if ($this->dataNotLoaded) {
throw new \Exception('Data column was not loaded from the database. Make sure the data column is selected in the query.');
}
$dataColumn = static::getDataColumn();
$customColumns = static::getCustomColumns();
$attributes = array_filter($this->getAttributes(), fn ($key) => ! in_array($key, $customColumns), ARRAY_FILTER_USE_KEY);
@ -107,11 +113,14 @@ trait VirtualColumn
return [
'retrieved' => [
function () {
// If the data column wasn't retrieved, don't decode it
if (($this->attributes[static::getDataColumn()] ?? null) === null) {
$this->dataNotLoaded = true;
return;
}
// Always decode after model retrieval
// Mark the data as encoded so that it doesn't get encoded again
$this->dataEncoded = true;
$this->decodeVirtualColumn();

14
tests/VirtualColumnTest.php
View file

@ -128,6 +128,20 @@ class VirtualColumnTest extends TestCase
$this->assertSame($encodedBar->bar, 'bar');
}
/** @test */
public function model_doesnt_overwrite_when_selectively_fetching() {
$this->expectExceptionMessage('Data column was not loaded from the database. Make sure the data column is selected in the query.');
FooModel::create([
'id' => 1,
'foo' => 'bar'
]);
$foo = FooModel::query()->first(['id']);
$foo->bar = 'baz';
$foo->save();
}
/** @test */
public function decoding_works_with_strict_mode_enabled() {
FooModel::shouldBeStrict();