From 73d7918170c8f68275f095e85b2c800a67cc94a6 Mon Sep 17 00:00:00 2001 From: lukinovec Date: Fri, 21 Oct 2022 13:56:03 +0200 Subject: [PATCH] Rename generateColumnName --- src/VirtualColumn.php | 2 +- tests/VirtualColumnTest.php | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/VirtualColumn.php b/src/VirtualColumn.php index 7a177e0..1943a80 100644 --- a/src/VirtualColumn.php +++ b/src/VirtualColumn.php @@ -140,7 +140,7 @@ trait VirtualColumn ]; } - public function generateColumnName(string $column): string + public function getColumnForQuery(string $column): string { if (in_array($column, static::getCustomColumns())) { return $column; diff --git a/tests/VirtualColumnTest.php b/tests/VirtualColumnTest.php index 88a198b..247b189 100644 --- a/tests/VirtualColumnTest.php +++ b/tests/VirtualColumnTest.php @@ -101,8 +101,8 @@ class VirtualColumnTest extends TestCase 'foo' => $virtualColumnName ]); - $this->assertSame($customColumnName, $model->generateColumnName('custom1')); - $this->assertSame($virtualColumnName, $model->generateColumnName('foo')); + $this->assertSame($customColumnName, $model->getColumnForQuery('custom1')); + $this->assertSame($virtualColumnName, $model->getColumnForQuery('foo')); } // maybe add an explicit test that the saving() and updating() listeners don't run twice?