archtechx/tenancy
1
0
Fork 0
mirror of https://github.com/archtechx/tenancy.git synced 2026-09-20 15:34:03 +00:00
Code Activity

Use rmdir instead of deleteDirectory

Browse source 
rmdir refuses to delete non-empty directories, so it's the better alternative to deleteDirectory here.
This commit is contained in:
lukinovec 2026-09-15 11:09:40 +02:00
parent 388f253964
commit 35d96b5b6f
1 changed files with 4 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/Actions/RemoveStorageSymlinksAction.php
View file

@ -68,7 +68,10 @@ class RemoveStorageSymlinksAction
// Remove the directories CreateStorageSymlinksAction created for the symlink // Remove the directories CreateStorageSymlinksAction created for the symlink
// until a non-empty one is reached. // until a non-empty one is reached.
while (str_starts_with(rtrim($directory, '/\\'), rtrim($publicRoot, '/\\') . DIRECTORY_SEPARATOR) && $files->isEmptyDirectory($directory)) { while (str_starts_with(rtrim($directory, '/\\'), rtrim($publicRoot, '/\\') . DIRECTORY_SEPARATOR) && $files->isEmptyDirectory($directory)) {
$files->deleteDirectory($directory); if (! @rmdir($directory)) {
// Stop the loop if the directory couldn't be removed
break;
}
$directory = dirname($directory); $directory = dirname($directory);
} }